From: Dave Jones <davej@redhat.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Tommi Rantala <tt.rantala@gmail.com>, trinity@vger.kernel.org
Subject: Re: [patch] perf_event_open enable sysfs exported events
Date: Thu, 13 Jun 2013 17:05:04 -0400 [thread overview]
Message-ID: <20130613210504.GB5440@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1306131706250.4638@vincent-weaver-1.um.maine.edu>
On Thu, Jun 13, 2013 at 05:07:59PM -0400, Vince Weaver wrote:
> On Thu, 13 Jun 2013, Dave Jones wrote:
> >
> > Probably safer ?
> >
> > + *type = rand32() | 1;
> > + *config1 = rand64() | 1;
> > + return rand64() | 1;
>
> no, 0 is a perfectly valid value for all of those fields.
>
> The error was coming in to play because if sysfs wasn't found, num_pmus
> was set to 0, and we were doing a " rand() % num_pmus " to choose
> a random value for the type field.
ah, gotcha. I'll queue up your patch.
thanks,
Dave
next prev parent reply other threads:[~2013-06-13 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 4:33 [patch] perf_event_open enable sysfs exported events Vince Weaver
2013-06-11 21:05 ` Dave Jones
2013-06-11 21:24 ` Vince Weaver
2013-06-11 21:32 ` Dave Jones
2013-06-11 22:21 ` Vince Weaver
2013-06-11 22:25 ` Dave Jones
2013-06-13 19:38 ` Tommi Rantala
2013-06-13 19:58 ` Vince Weaver
2013-06-13 20:53 ` Dave Jones
2013-06-13 21:07 ` Vince Weaver
2013-06-13 21:05 ` Dave Jones [this message]
2013-06-19 15:27 ` Dave Jones
2013-06-19 16:34 ` Vince Weaver
2013-06-19 16:38 ` Dave Jones
2013-06-19 19:29 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613210504.GB5440@redhat.com \
--to=davej@redhat.com \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox