From: Dave Jones <davej@redhat.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Vince Weaver <vincent.weaver@maine.edu>, trinity@vger.kernel.org
Subject: Re: [patch 1/2] add init() function to struct syscall
Date: Thu, 20 Jun 2013 00:48:10 -0400 [thread overview]
Message-ID: <20130620044810.GA28377@redhat.com> (raw)
In-Reply-To: <1371701715.21846.33.camel@concordia>
On Thu, Jun 20, 2013 at 02:15:15PM +1000, Michael Ellerman wrote:
> On Wed, 2013-06-19 at 22:40 -0400, Dave Jones wrote:
> > Nothing wrong with this patch, but it's highlighted a bug that's been in trinity
> > for a while. Changes to the syscall struct should cause everything in syscalls/*
> > to be rebuilt. But somehow the dependency magic in the Makefile doesn't pick it up.
> >
> > Anyone with better make-fu than me want to take a stab at that ?
>
> I'm not a make expert, but I think it's because it's looking for .deps/syscalls/foo.d
> whereas we generate .deps/foo.d
Bah, I knew it would be something that simple that I was overlooking.
> This patch works for me, touching include/syscall.h rebuilds a few
> things and then everything under syscalls.
Looks good to me.
> I guess the other approach would be to flatten the directory structure
> where we include the .d files.
That sounds like it would be a mess if we're unfortunate enough to have the same
name file in 2 dirs. Your patch seems to do the right thing, so I'll
just apply that and move on.
thanks
Dave
next prev parent reply other threads:[~2013-06-20 4:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 2:09 [patch 1/2] add init() function to struct syscall Vince Weaver
2013-06-20 2:10 ` [patch 2/2] make perf_event_open() use init routine Vince Weaver
2013-06-20 2:38 ` [patch 1/2] add init() function to struct syscall Dave Jones
2013-06-20 2:40 ` Dave Jones
2013-06-20 4:15 ` Michael Ellerman
2013-06-20 4:48 ` Dave Jones [this message]
2013-06-20 9:33 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620044810.GA28377@redhat.com \
--to=davej@redhat.com \
--cc=michael@ellerman.id.au \
--cc=trinity@vger.kernel.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox