From: Andi Kleen <andi@firstfloor.org>
To: Vince Weaver <vince@deater.net>
Cc: Andi Kleen <andi@firstfloor.org>, Andi Kleen <ak@linux.intel.com>,
acme@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
torvalds@linux-foundation.org, trinity@vger.kernel.org
Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2
Date: Wed, 24 Jul 2013 21:05:37 +0200 [thread overview]
Message-ID: <20130724190537.GW6123@two.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1307241433380.8230@pianoman.cluster.toy>
> I'd prefer if it were
>
> precise_ip:0-1
>
> as the code you use to set the value looks like
> attr->precise_ip=2;
> I don't think you can even set bits 15-16 of flags directly, can you?
Sorry I meant flags as an alias of "the 64bits currently occupied by the
bitfield". Perhaps the name choice was not very good.
"flags_bitfield" ?
So the tool would only need to know that, not every bit.
In theory it could be also generalized as a byte offset to perf_event,
but that may be overengineered.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2013-07-24 19:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1374501138-13496-1-git-send-email-andi@firstfloor.org>
[not found] ` <alpine.DEB.2.02.1307230137160.18617@pianoman.cluster.toy>
[not found] ` <20130723060108.GA18396@tassilo.jf.intel.com>
2013-07-23 21:27 ` [PATCH 1/2] tools, perf: Add a precise event qualifier v2 Vince Weaver
2013-07-23 22:51 ` Andi Kleen
2013-07-24 0:39 ` Sasha Levin
2013-07-24 1:33 ` Andi Kleen
2013-07-24 18:31 ` Vince Weaver
2013-07-24 18:54 ` Vince Weaver
2013-07-24 18:47 ` Vince Weaver
2013-07-24 19:05 ` Andi Kleen [this message]
2013-07-26 3:58 ` Vince Weaver
2013-09-12 16:57 ` Ingo Molnar
2013-09-12 17:36 ` Andi Kleen
2013-09-12 17:59 ` Ingo Molnar
2013-09-13 8:56 ` Peter Zijlstra
2013-09-13 9:50 ` Ingo Molnar
2013-09-13 11:29 ` Peter Zijlstra
2013-09-13 14:31 ` Vince Weaver
2013-09-13 17:48 ` Andi Kleen
2013-09-12 19:35 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724190537.GW6123@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=trinity@vger.kernel.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox