public inbox for trinity@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Andi Kleen" <andi@firstfloor.org>,
	"Vince Weaver" <vince@deater.net>,
	"Andi Kleen" <ak@linux.intel.com>,
	acme@infradead.org, linux-kernel@vger.kernel.org,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Stephane Eranian" <eranian@google.com>,
	torvalds@linux-foundation.org, trinity@vger.kernel.org,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Jiri Olsa" <jolsa@redhat.com>,
	"Namhyung Kim" <namhyung@gmail.com>
Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2
Date: Thu, 12 Sep 2013 19:36:17 +0200	[thread overview]
Message-ID: <20130912173617.GI18242@two.firstfloor.org> (raw)
In-Reply-To: <20130912165733.GA23698@gmail.com>

> Your feature to export 'precise' requirements on events looks useful to 
> me. We could implement it not by special casing it implicitly but by 
> saying that if ../format/precise contains something like:
> 
>    attr:240-241
> 
> then that's a natural extension of the config:X-Y format and should be 
> interpreted to mean mean 2 bits in the perf attr field. I.e. we could go 
> beyond the config bitfield.
> 
> Basically the whole perf_event_attr can be thought of as a 'giant 
> bitfield', in which we can specify values to export an enumerated list of 
> events from the kernel to tooling.
> 
> (Using attr:X-Y the config and config1 variants can be expressed as well, 
> as the config fields are inside the attr structure.)
> 
> The positions within the perf_attr are an ABI, so this would work pretty 
> well.

Wouldn't we need different bits for each architecture then?
32bit/64bit, some archs with weird alignment rules, maybe different for
BE/LE too?

Ok I suppose it could be somehow auto generated in asm-offsets.c,
although I'm not sure how to get a bitfield offset there.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2013-09-12 17:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1374501138-13496-1-git-send-email-andi@firstfloor.org>
     [not found] ` <alpine.DEB.2.02.1307230137160.18617@pianoman.cluster.toy>
     [not found]   ` <20130723060108.GA18396@tassilo.jf.intel.com>
2013-07-23 21:27     ` [PATCH 1/2] tools, perf: Add a precise event qualifier v2 Vince Weaver
2013-07-23 22:51       ` Andi Kleen
2013-07-24  0:39         ` Sasha Levin
2013-07-24  1:33           ` Andi Kleen
2013-07-24 18:31             ` Vince Weaver
2013-07-24 18:54           ` Vince Weaver
2013-07-24 18:47         ` Vince Weaver
2013-07-24 19:05           ` Andi Kleen
2013-07-26  3:58             ` Vince Weaver
2013-09-12 16:57         ` Ingo Molnar
2013-09-12 17:36           ` Andi Kleen [this message]
2013-09-12 17:59             ` Ingo Molnar
2013-09-13  8:56             ` Peter Zijlstra
2013-09-13  9:50               ` Ingo Molnar
2013-09-13 11:29                 ` Peter Zijlstra
2013-09-13 14:31                   ` Vince Weaver
2013-09-13 17:48               ` Andi Kleen
2013-09-12 19:35           ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912173617.GI18242@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=trinity@vger.kernel.org \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox