public inbox for trinity@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Fixed several FIXME items, removed unnecessary search over syscall names.
Date: Mon, 23 Sep 2013 09:35:34 -0400	[thread overview]
Message-ID: <20130923133534.GA8971@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309201553510.393@ildarm-linux.kir.corp.google.com>

On Fri, Sep 20, 2013 at 04:05:02PM -0700, Ildar Muslukhov wrote:
 > 
 > Hello everyone,
 > 
 > This isn't small patch but most of it was to remove silly loop in the 
 > child_random_syscalls function. The way I did it is by introducing an 
 > array of activated syscalls, which contains an index of the syscall in the 
 > syscalltable(32/64). This way we do not loop, just select one that is 
 > active and proceed.
 > 
 > Also, improved toggle_syscall functions (for biarch and not) by removing 
 > search by name as much as possible, thus, no need for loopup_name function 
 > anymore.
 > 
 > Furthermore, instead of commented out section of code (abbriviated with 
 > FIXME) that never selected 32 bit version of syscall if a 64 bit version 
 > existed I added a parameter to control this selection (more in README 
 > file). By default the chances will be 50/50, but one can control it.
 > 
 > Finally, cleaned up some areas (e.g., got rid of COLOR_ARG macro, by 
 > converting it to a function) and fixed one bug with wrong variable being 
 > used.

These need breaking up into separate patches.

	Dave

      reply	other threads:[~2013-09-23 13:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 23:05 [PATCH] Fixed several FIXME items, removed unnecessary search over syscall names Ildar Muslukhov
2013-09-23 13:35 ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130923133534.GA8971@redhat.com \
    --to=davej@redhat.com \
    --cc=ildarm@google.com \
    --cc=trinity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox