From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [Patch suggestion] Probability flag for 32 bit syscalls
Date: Tue, 24 Sep 2013 14:50:45 -0400 [thread overview]
Message-ID: <20130924185045.GB21307@redhat.com> (raw)
In-Reply-To: <CAEGbLtsPpimeDotO09H7Lqm0p=RKmaX1DR05Mu60=c9fazacCA@mail.gmail.com>
On Tue, Sep 24, 2013 at 11:36:53AM -0700, Ildar Muslukhov wrote:
> Hi everyone,
>
> In the children/random-syscalls.c file (function choose_syscall_table)
> there is a FIXME section that right now disables 32 bit version of
> syscall if a 64 bit version is present and enabled.
>
> // FIXME: I forgot why this got disabled. Revisit.
> // if (rand() % 100 < 10)
> //
>
> Just want to clear this one out. Should it be a command line
> parameter? Something like -P 50 (for 50% probability, lets say of 32
> bit). If so, what should be a default behaviour when the parameter is
> not present 50/50 or 0/100 as it is right now.
So that got disabled a long time ago. Back in May of last year in commit
2d4de3c15fa80c42cccb1863fbd7879ef5aeaf38.
I'm not sure that ever got fixed up. It might be worth doing some long
runs to see if it's still a problem.
Dave
next prev parent reply other threads:[~2013-09-24 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 18:36 [Patch suggestion] Probability flag for 32 bit syscalls Ildar Muslukhov
2013-09-24 18:50 ` Dave Jones [this message]
2013-09-24 19:03 ` Ildar Muslukhov
2013-09-24 19:21 ` Dave Jones
2013-09-25 20:25 ` Ildar Muslukhov
2013-09-25 20:32 ` Dave Jones
2013-09-25 20:43 ` Ildar Muslukhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924185045.GB21307@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox