* Re: [PATCH] Added ability to select only 32 or 64 bit syscall [not found] <CAEGbLtsPA2MvD_=s7ASTg8fkWD-cGHPk=ePGNPnZaALc_XDtsg@mail.gmail.com> @ 2013-09-27 21:49 ` Dave Jones 2013-09-30 16:51 ` Ildar Muslukhov 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2013-09-27 21:49 UTC (permalink / raw) To: Ildar Muslukhov; +Cc: trinity On Fri, Sep 13, 2013 at 12:53:16PM -0700, Ildar Muslukhov wrote: > This patch explicit selection of 32 or 64 bit version of a syscall via > parameter. I only just noticed this.. > - fprintf(stderr, " -c#: target specific syscall (takes syscall name as parameter).\n"); > + fprintf(stderr, " -c#,@: target specific syscall (takes syscall name as parameter and @ as architecture. No @ defaults to both archs.).\n"); The patch I ended up applying looks like it doesn't touch -c parsing. Is this incomplete ? Dave ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added ability to select only 32 or 64 bit syscall 2013-09-27 21:49 ` [PATCH] Added ability to select only 32 or 64 bit syscall Dave Jones @ 2013-09-30 16:51 ` Ildar Muslukhov 2013-09-30 17:07 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Ildar Muslukhov @ 2013-09-30 16:51 UTC (permalink / raw) To: Dave Jones; +Cc: trinity Nope, The splitting of the parameter is done in the toggle_syscall function. -Ildar On Fri, Sep 27, 2013 at 2:49 PM, Dave Jones <davej@redhat.com> wrote: > On Fri, Sep 13, 2013 at 12:53:16PM -0700, Ildar Muslukhov wrote: > > This patch explicit selection of 32 or 64 bit version of a syscall via > > parameter. > > I only just noticed this.. > > > - fprintf(stderr, " -c#: target specific syscall (takes syscall name as parameter).\n"); > > + fprintf(stderr, " -c#,@: target specific syscall (takes syscall name as parameter and @ as architecture. No @ defaults to both archs.).\n"); > > The patch I ended up applying looks like it doesn't touch -c parsing. > Is this incomplete ? > > Dave > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added ability to select only 32 or 64 bit syscall 2013-09-30 16:51 ` Ildar Muslukhov @ 2013-09-30 17:07 ` Dave Jones 2013-09-30 17:28 ` Ildar Muslukhov 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2013-09-30 17:07 UTC (permalink / raw) To: Ildar Muslukhov; +Cc: trinity On Mon, Sep 30, 2013 at 09:51:02AM -0700, Ildar Muslukhov wrote: > On Fri, Sep 27, 2013 at 2:49 PM, Dave Jones <davej@redhat.com> wrote: > > On Fri, Sep 13, 2013 at 12:53:16PM -0700, Ildar Muslukhov wrote: > > > This patch explicit selection of 32 or 64 bit version of a syscall via > > > parameter. > > > > I only just noticed this.. > > > > > - fprintf(stderr, " -c#: target specific syscall (takes syscall name as parameter).\n"); > > > + fprintf(stderr, " -c#,@: target specific syscall (takes syscall name as parameter and @ as architecture. No @ defaults to both archs.).\n"); > > > > The patch I ended up applying looks like it doesn't touch -c parsing. > > Is this incomplete ? > > Nope, > > The splitting of the parameter is done in the toggle_syscall function. Ok, then I'm confused, because the syntax above doesn't seem to parse architecture. $ ./trinity -c open,x86_64 Trinity v1.3pre Dave Jones <davej@redhat.com> No idea what architecture for syscall (open,x86_64) is Dave ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added ability to select only 32 or 64 bit syscall 2013-09-30 17:07 ` Dave Jones @ 2013-09-30 17:28 ` Ildar Muslukhov 2013-09-30 17:34 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Ildar Muslukhov @ 2013-09-30 17:28 UTC (permalink / raw) To: Dave Jones; +Cc: trinity I see, I though of this as a bad wording since architecture means different things but what we are really doing in this parameter is picking between 64 and 32 bit types, which is also an architecture. Right now it expects 32 or 64 as an architecture. Thus you need to run like $./trinity -c open,32 On Mon, Sep 30, 2013 at 10:07 AM, Dave Jones <davej@redhat.com> wrote: > On Mon, Sep 30, 2013 at 09:51:02AM -0700, Ildar Muslukhov wrote: > > > On Fri, Sep 27, 2013 at 2:49 PM, Dave Jones <davej@redhat.com> wrote: > > > On Fri, Sep 13, 2013 at 12:53:16PM -0700, Ildar Muslukhov wrote: > > > > This patch explicit selection of 32 or 64 bit version of a syscall via > > > > parameter. > > > > > > I only just noticed this.. > > > > > > > - fprintf(stderr, " -c#: target specific syscall (takes syscall name as parameter).\n"); > > > > + fprintf(stderr, " -c#,@: target specific syscall (takes syscall name as parameter and @ as architecture. No @ defaults to both archs.).\n"); > > > > > > The patch I ended up applying looks like it doesn't touch -c parsing. > > > Is this incomplete ? > > > > Nope, > > > > The splitting of the parameter is done in the toggle_syscall function. > > Ok, then I'm confused, because the syntax above doesn't seem to parse architecture. > > $ ./trinity -c open,x86_64 > Trinity v1.3pre Dave Jones <davej@redhat.com> > No idea what architecture for syscall (open,x86_64) is > > Dave > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added ability to select only 32 or 64 bit syscall 2013-09-30 17:28 ` Ildar Muslukhov @ 2013-09-30 17:34 ` Dave Jones 0 siblings, 0 replies; 5+ messages in thread From: Dave Jones @ 2013-09-30 17:34 UTC (permalink / raw) To: Ildar Muslukhov; +Cc: trinity On Mon, Sep 30, 2013 at 10:28:27AM -0700, Ildar Muslukhov wrote: > I see, I though of this as a bad wording since architecture means > different things but what we are really doing in this parameter is > picking between 64 and 32 bit types, which is also an architecture. > Right now it expects 32 or 64 as an architecture. Thus you need to run > like > $./trinity -c open,32 duh. Reading the diff now, it seems obvious. Still, I just committed some reworded --help text, and also the error message. thanks, Dave ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-30 17:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAEGbLtsPA2MvD_=s7ASTg8fkWD-cGHPk=ePGNPnZaALc_XDtsg@mail.gmail.com>
2013-09-27 21:49 ` [PATCH] Added ability to select only 32 or 64 bit syscall Dave Jones
2013-09-30 16:51 ` Ildar Muslukhov
2013-09-30 17:07 ` Dave Jones
2013-09-30 17:28 ` Ildar Muslukhov
2013-09-30 17:34 ` Dave Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox