From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Added ability to select only 32 or 64 bit syscall
Date: Mon, 30 Sep 2013 13:07:12 -0400 [thread overview]
Message-ID: <20130930170712.GA9455@redhat.com> (raw)
In-Reply-To: <CAEGbLtsonrCxxeNxfDW0t91R32=6HhfeWWh7_dwnJChNM7pbhg@mail.gmail.com>
On Mon, Sep 30, 2013 at 09:51:02AM -0700, Ildar Muslukhov wrote:
> On Fri, Sep 27, 2013 at 2:49 PM, Dave Jones <davej@redhat.com> wrote:
> > On Fri, Sep 13, 2013 at 12:53:16PM -0700, Ildar Muslukhov wrote:
> > > This patch explicit selection of 32 or 64 bit version of a syscall via
> > > parameter.
> >
> > I only just noticed this..
> >
> > > - fprintf(stderr, " -c#: target specific syscall (takes syscall name as parameter).\n");
> > > + fprintf(stderr, " -c#,@: target specific syscall (takes syscall name as parameter and @ as architecture. No @ defaults to both archs.).\n");
> >
> > The patch I ended up applying looks like it doesn't touch -c parsing.
> > Is this incomplete ?
>
> Nope,
>
> The splitting of the parameter is done in the toggle_syscall function.
Ok, then I'm confused, because the syntax above doesn't seem to parse architecture.
$ ./trinity -c open,x86_64
Trinity v1.3pre Dave Jones <davej@redhat.com>
No idea what architecture for syscall (open,x86_64) is
Dave
next prev parent reply other threads:[~2013-09-30 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEGbLtsPA2MvD_=s7ASTg8fkWD-cGHPk=ePGNPnZaALc_XDtsg@mail.gmail.com>
2013-09-27 21:49 ` [PATCH] Added ability to select only 32 or 64 bit syscall Dave Jones
2013-09-30 16:51 ` Ildar Muslukhov
2013-09-30 17:07 ` Dave Jones [this message]
2013-09-30 17:28 ` Ildar Muslukhov
2013-09-30 17:34 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930170712.GA9455@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox