From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Fix syscall32 to supply 6th arg to syscal
Date: Wed, 2 Oct 2013 12:43:37 -0400 [thread overview]
Message-ID: <20131002164337.GA17276@redhat.com> (raw)
In-Reply-To: <CAEGbLtv4wtaRuTVDPxpQcg0WWv2jDaa59vpX5MHTWe=gz-zBoQ@mail.gmail.com>
On Wed, Oct 02, 2013 at 09:14:43AM -0700, Ildar Muslukhov wrote:
> On Wed, Oct 2, 2013 at 8:12 AM, Dave Jones <davej@redhat.com> wrote:
> > On Thu, Sep 19, 2013 at 02:24:24PM -0700, Ildar Muslukhov wrote:
> > >
> > > This patch fixes missing 6th param for 32bit syscalls in i386 and x86_64
> > > archs.
> >
> > Something isn't quite right with this.
> > I was looking at a log file and noticed that in a lot of cases, we end up
> > doing a 32bit syscall, and then the child respawns. I suspected it
> > was segfaulting, and running with -D confirms it.
> >
> > A whole bunch of core dumps appears, looking like this..
> >
> > Core was generated by `../trinity -q -D'.
> > Program terminated with signal 11, Segmentation fault.
> > #0 0x0000000000403aa5 in syscall32 (a6=<optimized out>, a5=5, a4=9709, a3=29, a2=4, a1=<optimized out>, call=279, num_args=5) at syscall.c:76
> > 76 __syscall_return(long,__res);
> >
> > This is running on x86-64, I haven't tested actually running on a 32-bit machine,
> > but I suspect it's a problem there too.
>
> Yes, it gave me problems in the beginning, but after removing static
> from the function and taking care of ebp it worked. Will test it on my
> machine in a moment. BTW which kernel version are you running against?
Happens with 3.11, and Linus' git. Seems to not matter.
Dave
next prev parent reply other threads:[~2013-10-02 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:24 [PATCH] Fix syscall32 to supply 6th arg to syscal Ildar Muslukhov
2013-09-19 21:35 ` Dave Jones
2013-10-02 15:12 ` Dave Jones
2013-10-02 16:14 ` Ildar Muslukhov
2013-10-02 16:43 ` Dave Jones [this message]
2013-10-02 18:12 ` Ildar Muslukhov
2013-10-02 18:15 ` Dave Jones
2013-10-02 20:44 ` Ildar Muslukhov
2013-10-02 20:48 ` Dave Jones
2013-10-02 20:53 ` Ildar Muslukhov
2013-10-02 20:57 ` Dave Jones
2013-10-02 21:03 ` Ildar Muslukhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002164337.GA17276@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox