From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: Patch suggestion - logs cleanup
Date: Fri, 4 Oct 2013 16:05:19 -0400 [thread overview]
Message-ID: <20131004200519.GA10511@redhat.com> (raw)
In-Reply-To: <CAEGbLtsVDped4dT1z7Bbr6dxXbhET+R9D-P3uEjsx+GeFM6rBg@mail.gmail.com>
On Fri, Oct 04, 2013 at 12:34:35PM -0700, Ildar Muslukhov wrote:
> What do you think if we combine -l, -q and -v parameters in the following way:
> absence of the parameter will set log level to base (1)
> -l off will work as it is right now (logging is off)
> -l N is setup of the level (i.e., -l 1 will be equal to the default
> settings, where N can be from 0 to 2 as it is right now).
>
> This way we can simplify the log handling from source code point of
> view. Having three parameters which might collide with each other
> seems rather error prone.
Combining them might mean we can't express some existing use-cases though.
Verbosity of the messages to the screen vs what gets logged to disk are kind
of separate things.
Valid right now:
logging to disk, no output to screen other than seed. (-qq)
logging to disk, output seeds & watchdog progress counter (-q)
logging to disk, syscall details (no args)
logging to disk, verbose output (-v)
and 'no log' variants of all.
I'm not sure we can really express 8 possibilities into one arg and
without people needing to look up what the values represent.
Dave
next prev parent reply other threads:[~2013-10-04 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 0:04 Patch suggestion - logs cleanup Ildar Muslukhov
2013-10-03 0:11 ` Dave Jones
2013-10-03 17:31 ` Ildar Muslukhov
2013-10-03 17:50 ` Dave Jones
2013-10-04 19:34 ` Ildar Muslukhov
2013-10-04 20:05 ` Dave Jones [this message]
2013-10-04 20:07 ` Ildar Muslukhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004200519.GA10511@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox