From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Logs cleanup
Date: Mon, 7 Oct 2013 22:43:15 -0400 [thread overview]
Message-ID: <20131008024315.GA31588@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1310071817130.27197@ildarm-linux.kir.corp.google.com>
On Mon, Oct 07, 2013 at 06:26:18PM -0700, Ildar Muslukhov wrote:
>
> This patch removes almost all printf and wires them into output functions,
> defined in log.c. As a result this patch also fixes bugs with "stack smash
> detected" and emission of ANSI control symbols even if -m (monochrome
> mode) is specified.
>
> I gave it a run for couple of hours with differnt parameters, seems to be
> working, but worth additional testing, since it touches many files.
>
> Signed-off-by: Ildar Muslukhov <ildarm@google.com>
Just like last time, this needs chopping into lots of smaller patches.
It's unreviewable when you make many changes in one diff like this.
Your workflow should be using git commit often, for the smallest possible change,
and then when you're done, post a series of patches generated with 'git format-diff origin..'
Dave
prev parent reply other threads:[~2013-10-08 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 1:26 [PATCH] Logs cleanup Ildar Muslukhov
2013-10-08 2:43 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008024315.GA31588@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox