From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH 4/6] wired in output function instead of printf (and some missing outputstd)
Date: Wed, 9 Oct 2013 17:40:59 -0400 [thread overview]
Message-ID: <20131009214059.GA26164@redhat.com> (raw)
In-Reply-To: <20131009162336.GA2821@redhat.com>
On Wed, Oct 09, 2013 at 12:23:36PM -0400, Dave Jones wrote:
> On Tue, Oct 08, 2013 at 02:26:53PM -0700, Ildar Muslukhov wrote:
>
>
> > void set_seed(unsigned int pidslot)
> > {
> > + pid_t pid = getpid();
> > + if ((pid != watchdog_pid) && (pid != initpid) && (pid != mainpid))
>
> As a follow-on patch, I suggest splitting this out into an is_child_pid() helper.
on second thought, the printing of the seed from the child is a) pointless because
we can infer it from the main seed, and b) really noisy (especially when you run a lot of children).
let's drop this chunk
Dave
next prev parent reply other threads:[~2013-10-09 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 21:26 [PATCH 1/6] added outputerr/outputstd log functions Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 2/6] wired outputstd/err functions Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 3/6] refactored output function Ildar Muslukhov
2013-10-10 18:20 ` Dave Jones
2013-10-15 17:07 ` Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 4/6] wired in output function instead of printf (and some missing outputstd) Ildar Muslukhov
2013-10-09 16:23 ` Dave Jones
2013-10-09 21:40 ` Dave Jones [this message]
2013-10-08 21:26 ` [PATCH 5/6] added bufferless logging functions for syscall pamaters Ildar Muslukhov
2013-10-09 16:27 ` Dave Jones
2013-10-08 21:26 ` [PATCH 6/6] wired syscall parameters logging function into syscall (this should fix stack smash bug detected) Ildar Muslukhov
2013-10-09 16:28 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009214059.GA26164@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox