From: Dave Jones <davej@redhat.com>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH 04/12] configure.sh: show error output when something is not found
Date: Fri, 18 Oct 2013 14:07:17 -0400 [thread overview]
Message-ID: <20131018180717.GA29546@redhat.com> (raw)
In-Reply-To: <20131018180019.GA26183@redhat.com>
On Fri, Oct 18, 2013 at 02:00:19PM -0400, Dave Jones wrote:
> On Wed, Oct 16, 2013 at 01:43:22PM +0300, Mikko Rapeli wrote:
> > It can be a configuration or ortherwise important warning/error.
> >
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
>
> I don't like this one, because in most cases, these aren't important.
> On some machines, we even expect some of them to fail. Example, on a Fedora 19
> system we run this test, which we expect to fail..
>
>
> [*] Checking if glibc headers provide termios2.. [NO]
> /home/davej/tmp/tmp.U0xuPLOakW.c: In function ‘main’:
> /home/davej/tmp/tmp.U0xuPLOakW.c:7:18: error: storage size of ‘test’ isn’t known
> struct termios2 test;
> ^
>
> Printing out an 'error' when there's nothing actually wrong seems alarmist.
> Especially when we do the right thing, and include the right header afterwards.
[PATCH 05/12] configure.sh: support cross compilation with sysroot
will need rebasing without this. I applied and pushed out everything else.
Dave
next prev parent reply other threads:[~2013-10-18 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 10:43 [PATCH 01/12] configure.sh: use colors only with terminal Mikko Rapeli
2013-10-16 10:43 ` [PATCH 02/12] configure.sh: use gcc as default compiler Mikko Rapeli
2013-10-17 4:23 ` Michael Ellerman
2013-10-17 6:45 ` Mikko Rapeli
2013-10-17 12:53 ` Michael Ellerman
2013-10-18 18:01 ` Dave Jones
2013-10-16 10:43 ` [PATCH 03/12] configure.sh: expand tilde from CROSS_COMPILE variable Mikko Rapeli
2013-10-16 10:43 ` [PATCH 04/12] configure.sh: show error output when something is not found Mikko Rapeli
2013-10-18 18:00 ` Dave Jones
2013-10-18 18:07 ` Dave Jones [this message]
2013-10-28 10:48 ` [PATCH v2] configure.sh: support cross compilation with sysroot Mikko Rapeli
2013-10-16 10:43 ` [PATCH 05/12] " Mikko Rapeli
2013-10-16 10:43 ` [PATCH 06/12] Makefile: use gcc as compiler Mikko Rapeli
2013-10-16 10:43 ` [PATCH 07/12] Makefile: support sysroot for libs and includes Mikko Rapeli
2013-10-16 10:43 ` [PATCH 08/12] Define IP_MULTICAST_ALL if header files don't have it Mikko Rapeli
2013-10-16 10:43 ` [PATCH 09/12] net/irda_setsockopt.c: workaround for old irda headers Mikko Rapeli
2013-10-16 10:43 ` [PATCH 10/12] net/netlink.c: support older kernels and headers Mikko Rapeli
2013-10-16 10:43 ` [PATCH 11/12] net/netlink_setsockopt.c: workaround for old headers Mikko Rapeli
2013-10-16 10:43 ` [PATCH 12/12] Makefile: install depends on trinity target Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018180717.GA29546@redhat.com \
--to=davej@redhat.com \
--cc=mikko.rapeli@iki.fi \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox