From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Dave Jones <davej@redhat.com>
Cc: trinity@vger.kernel.org, Vladimir Davydov <vdavydov@parallels.com>
Subject: Re: [PATCH 0/4] Teach trinity to not use some sockets family
Date: Fri, 1 Nov 2013 00:05:45 +0400 [thread overview]
Message-ID: <20131031200545.GF9860@moon> (raw)
In-Reply-To: <20131031194943.GA8696@redhat.com>
On Thu, Oct 31, 2013 at 03:49:43PM -0400, Dave Jones wrote:
> On Fri, Oct 25, 2013 at 11:48:58AM +0400, Cyrill Gorcunov wrote:
> > On Fri, Oct 25, 2013 at 1:39 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > > When I've been running trinity on testing machine admins were
> > > not that happy about traffic generated by trinity (especially
> > > ones created with packet socket). So here is an attempt to teach
> > > trinity to use say only some set of sockets if needed with help
> > > of --fds option.
> > >
> > > Please take a look, thanks.
> >
> > Drop the serice please, it'll be reworked.
>
> I'm about to apply your later series, but I noticed that that one
> instead of the --fds patch, has the -E change.
>
> Do you still plan on submitting the --fds change later?
> The reason I ask is that it if we're doing --fds, then it might at some point
> mean we can deprecate (and then remove) use of -P in favor of it, so adding an
> inverse (-E) seems odd.
Hi Dave! To be fair, not sure at moment. Initially I wanted to implement a general
--fds option which might take more complex command line like sockets:PF_X,^PF_X and
such, then extend it to file:^pipe,epoll. But this end up in being somehow
more complex rework. So I decided to stick with simplier approach first -- -E option
which would exclude some socket protocols from being generated.
But sure, once time permit I can try to implement --fds option as well. Lets fisrt
summarize what kind of syntax it will carry.
--fds [sockets:PF_X,^PF_X,N,^N,all,none],[files:pipe,^epoll,all,none]
Sounds good?
next prev parent reply other threads:[~2013-10-31 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:39 [PATCH 0/4] Teach trinity to not use some sockets family Cyrill Gorcunov
2013-10-24 21:39 ` [PATCH 1/4] make: Add cscope target Cyrill Gorcunov
2013-10-24 21:39 ` [PATCH 2/4] log: Add BUG_ON helper Cyrill Gorcunov
2013-10-24 21:39 ` [PATCH 3/4] params: Add parsing of -f|--fds option Cyrill Gorcunov
2013-10-24 21:39 ` [PATCH 4/4] sockets: Take into account socket families disabled when generating sockets Cyrill Gorcunov
2013-10-25 7:48 ` [PATCH 0/4] Teach trinity to not use some sockets family Cyrill Gorcunov
2013-10-31 19:49 ` Dave Jones
2013-10-31 20:05 ` Cyrill Gorcunov [this message]
2013-10-31 20:20 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031200545.GF9860@moon \
--to=gorcunov@gmail.com \
--cc=davej@redhat.com \
--cc=trinity@vger.kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox