From: Tejun Heo <tj@kernel.org>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Tommi Rantala <tt.rantala@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
trinity@vger.kernel.org
Subject: Re: [PATCH ] workqueue: add args to workqueue lockdep name
Date: Fri, 14 Feb 2014 09:06:13 -0500 [thread overview]
Message-ID: <20140214140613.GA29516@htj.dyndns.org> (raw)
In-Reply-To: <1392346377.4744.8.camel@ThinkPad-T5421.cn.ibm.com>
On Fri, Feb 14, 2014 at 10:52:57AM +0800, Li Zhong wrote:
> Tommi noticed a 'funny' lock class name: "%s#5" from a lock acquired in
> process_one_work().
>
> Maybe #fmt plus #args could be used as the lock_name to give some more
> information for some fmt string like the above.
>
> __builtin_constant_p() check is removed (as there seems no good way to
> check all the variables in args list). However, by removing the check,
> it only adds two additional "s for those constants.
>
> Some lockdep name examples printed out after the change:
>
> lockdep name wq->name
>
> "events_long" events_long
> "%s"("khelper") khelper
> "xfs-data/%s"mp->m_fsname xfs-data/dm-3
>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Applied to wq/for-3.14-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2014-02-14 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 19:19 lockdep: strange %s#5 lock name Tommi Rantala
2014-02-10 19:28 ` Peter Zijlstra
2014-02-10 21:52 ` Tejun Heo
2014-02-11 11:00 ` Peter Zijlstra
2014-02-11 15:27 ` Tejun Heo
2014-02-13 4:35 ` Li Zhong
2014-02-13 21:26 ` Tejun Heo
2014-02-13 21:32 ` Peter Zijlstra
2014-02-13 22:15 ` Tejun Heo
2014-02-14 2:52 ` [PATCH ] workqueue: add args to workqueue lockdep name Li Zhong
2014-02-14 14:06 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214140613.GA29516@htj.dyndns.org \
--to=tj@kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).