compile error wrt VERSION

compile error wrt VERSION

[Toralf Förster]

At a 32 bit stable Gentoo Linux I do get (using make -j4):

gical-op -Wstrict-aliasing=3  -o devices.o -c devices.c
In file included from debug.c:13:0:
include/version.h:3:9: error: macro names must be identifiers
debug.c: In function ‘__BUG’:
debug.c:44:23: error: ‘VERSION’ undeclared (first use in this function)
debug.c:44:23: note: each undeclared identifier is reported only once for each function it appears in
make: *** [debug.o] Error 1
make: *** Waiting for unfinished jobs....


-- 
Toralf

Re: compile error wrt VERSION

[Dave Jones]

On Fri, Jul 11, 2014 at 04:25:47PM +0200, Toralf Förster wrote:
 > At a 32 bit stable Gentoo Linux I do get (using make -j4):
 > 
 > gical-op -Wstrict-aliasing=3  -o devices.o -c devices.c
 > In file included from debug.c:13:0:
 > include/version.h:3:9: error: macro names must be identifiers
 > debug.c: In function ‘__BUG’:
 > debug.c:44:23: error: ‘VERSION’ undeclared (first use in this function)
 > debug.c:44:23: note: each undeclared identifier is reported only once for each function it appears in
 > make: *** [debug.o] Error 1
 > make: *** Waiting for unfinished jobs....

interesting. Can you paste the contents of include/version.h ?

Does this system have git installed ? (Trying to figure out which
part of scripts/gen-versionh.sh is getting run)

	Dave
 

Re: compile error wrt VERSION

[Dave Jones]

On Fri, Jul 11, 2014 at 10:35:05AM -0400, Dave Jones wrote:
 > On Fri, Jul 11, 2014 at 04:25:47PM +0200, Toralf Förster wrote:
 >  > At a 32 bit stable Gentoo Linux I do get (using make -j4):
 >  > 
 >  > gical-op -Wstrict-aliasing=3  -o devices.o -c devices.c
 >  > In file included from debug.c:13:0:
 >  > include/version.h:3:9: error: macro names must be identifiers
 >  > debug.c: In function ‘__BUG’:
 >  > debug.c:44:23: error: ‘VERSION’ undeclared (first use in this function)
 >  > debug.c:44:23: note: each undeclared identifier is reported only once for each function it appears in
 >  > make: *** [debug.o] Error 1
 >  > make: *** Waiting for unfinished jobs....
 > 
 > interesting. Can you paste the contents of include/version.h ?
 > 
 > Does this system have git installed ? (Trying to figure out which
 > part of scripts/gen-versionh.sh is getting run)

ah, looks like I screwed up the "no git" case. I just pushed a fix.

	Dave

Re: compile error wrt VERSION

[Toralf Förster]

On 07/11/2014 04:38 PM, Dave Jones wrote:
> On Fri, Jul 11, 2014 at 10:35:05AM -0400, Dave Jones wrote:
>  > On Fri, Jul 11, 2014 at 04:25:47PM +0200, Toralf Förster wrote:
>  >  > At a 32 bit stable Gentoo Linux I do get (using make -j4):
>  >  > 
>  >  > gical-op -Wstrict-aliasing=3  -o devices.o -c devices.c
>  >  > In file included from debug.c:13:0:
>  >  > include/version.h:3:9: error: macro names must be identifiers
>  >  > debug.c: In function ‘__BUG’:
>  >  > debug.c:44:23: error: ‘VERSION’ undeclared (first use in this function)
>  >  > debug.c:44:23: note: each undeclared identifier is reported only once for each function it appears in
>  >  > make: *** [debug.o] Error 1
>  >  > make: *** Waiting for unfinished jobs....
>  > 
>  > interesting. Can you paste the contents of include/version.h ?
>  > 
>  > Does this system have git installed ? (Trying to figure out which
>  > part of scripts/gen-versionh.sh is getting run)
> 
> ah, looks like I screwed up the "no git" case. I just pushed a fix.

exactly - for the UML test scenario I do not have git.

The fix works - thx.


> 
> 	Dave
> 
> 


-- 
Toralf