From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: [patch] update perf_event_open() for Linux 3.19 Date: Wed, 4 Feb 2015 15:46:32 -0500 Message-ID: <20150204204632.GA2551@codemonkey.org.uk> References: <20150204203100.GA1842@codemonkey.org.uk> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: trinity-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vince Weaver Cc: trinity@vger.kernel.org On Wed, Feb 04, 2015 at 03:41:17PM -0500, Vince Weaver wrote: > On Wed, 4 Feb 2015, Dave Jones wrote: > > > On Tue, Feb 03, 2015 at 12:01:23PM -0500, Vince Weaver wrote: > > > > > > > @@ -237,6 +238,7 @@ enum perf_event_read_format { > > > #define PERF_ATTR_SIZE_VER2 80 /* add: branch_sample_type */ > > > #define PERF_ATTR_SIZE_VER3 96 /* add: sample_regs_user */ > > > /* add: sample_stack_user */ > > > +#define PERF_ATTR_SIZE_VER4 104 /* add: sample_regs_intr */ > > > > I've not given this a lot of thought before, but I'm assuming these > > are the 64-bit struct sizes. It might be interesting to also > > throw some 32-bit sizes in the mix. Who knows what horrors > > lie in wait for the compat syscalls. > > I might be misunderstanding, but I think the attr structure is defined in > a way that it has the same size on 32 and 64 bit. ah, ok. Yeah, now that I look at the struct definition, it's all u32/u64's, so this is the same size on both archs. Dave