Re: "invalid open call: O_CREAT or O_TMPFILE without mode" errors

["Kirill A. Shutemov" <kirill@shutemov.name>]

On Mon, Jul 20, 2015 at 10:52:57AM -0400, Dave Jones wrote:
> On Thu, Jul 16, 2015 at 04:38:21PM -0700, Vinson Lee wrote:
>  > Hi.
>  > 
>  > trinity stops running very soon after launch with invalid open call errors.
>  > 
>  > [main] Generating file descriptors
>  > [main] Added 104 filenames from /dev
>  > [main] Added 70615 filenames from /proc
>  > [main] Added 29037 filenames from /sys
>  > *** invalid open call: O_CREAT or O_TMPFILE without mode ***:
>  > ./trinity terminated
> 
> Ugh. Is that some shiny new glibc ?
> 
> Probably something like this ?
> 
> Totally untested, I don't have a lot of time right now.

There's one more source of such crashes: open_file() in fds/files.c

diff --git a/fds/files.c b/fds/files.c
index 2c7fa1ec1244..997cfea3fa18 100644
--- a/fds/files.c
+++ b/fds/files.c
@@ -321,7 +321,7 @@ retry_flags:
 
        if (RAND_BOOL()) {
                randflags = get_o_flags();
-               fd = open(filename, flags | randflags | O_NONBLOCK);
+               fd = open(filename, flags | randflags | O_NONBLOCK, 0666);
        } else {
                fd = open_with_fopen(filename, flags);
                fcntl_flags = random_fcntl_setfl_flags();
-- 
 Kirill A. Shutemov