From: Dave Jones <davej@codemonkey.org.uk>
To: Artem Savkov <asavkov@redhat.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Fix logging logic in output().
Date: Wed, 17 Feb 2016 11:55:18 -0500 [thread overview]
Message-ID: <20160217165518.GA6978@codemonkey.org.uk> (raw)
In-Reply-To: <1455726039-5525-1-git-send-email-asavkov@redhat.com>
On Wed, Feb 17, 2016 at 05:20:39PM +0100, Artem Savkov wrote:
> Commit "preparation for different forms of logging." contained a typo that
> broke logging to mainlogfile.
>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
> ---
> log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/log.c b/log.c
> index dbac844..aee5a67 100644
> --- a/log.c
> +++ b/log.c
> @@ -103,7 +103,7 @@ void output(unsigned char level, const char *fmt, ...)
> }
>
> /* go on with file logs only if enabled */
> - if (logging == LOGGING_FILES)
> + if (logging == LOGGING_DISABLED)
> return;
Duh, yeah, that's pretty silly. This prep work still hasn't materialised
into other forms of logging, but for now this is the obvious fix.
thanks,
Dave
prev parent reply other threads:[~2016-02-17 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 16:20 [PATCH] Fix logging logic in output() Artem Savkov
2016-02-17 16:55 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217165518.GA6978@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=asavkov@redhat.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).