From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Jones <davej@codemonkey.org.uk>
Subject: Re: [PATCH] fix build when USE_BPF is not defined
Date: Mon, 7 Nov 2016 09:34:35 -0500
Message-ID: <20161107143434.k54git2ujrkzrwly@codemonkey.org.uk>
References: <dc2c60882d0fe97a0c956dd856d74aa3347a3e5f.1478519712.git.jstancek@redhat.com>
Mime-Version: 1.0
Return-path: <trinity-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <dc2c60882d0fe97a0c956dd856d74aa3347a3e5f.1478519712.git.jstancek@redhat.com>
Sender: trinity-owner@vger.kernel.org
List-ID: <trinity.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Jan Stancek <jstancek@redhat.com>
Cc: trinity@vger.kernel.org

On Mon, Nov 07, 2016 at 12:58:34PM +0100, Jan Stancek wrote:
 > net/bpf.o: In function `bpf_gen_filter': bpf.c:852: undefined reference to `get_rand_bpf_fd'
 > 
 > Signed-off-by: Jan Stancek <jstancek@redhat.com>
 > ---
 >  net/bpf.c | 3 +++
 >  1 file changed, 3 insertions(+)
 > 
 > diff --git a/net/bpf.c b/net/bpf.c
 > index 4fe941733016..bb07a777abe9 100644
 > --- a/net/bpf.c
 > +++ b/net/bpf.c
 > @@ -8,6 +8,7 @@
 >  #include <string.h>
 >  
 >  #include "bpf.h"
 > +#include "config.h"
 >  #include "debug.h"
 >  #include "log.h"
 >  #include "net.h"
 > @@ -849,8 +850,10 @@ void bpf_gen_filter(unsigned long **addr, unsigned long *addrlen)
 >  		switch (rnd() % 3) {
 >  		case 0:	bpf->filter[i].k = (uint32_t) rand32();
 >  			break;
 > +#ifdef USE_BPF
 >  		case 1:	bpf->filter[i].k = (uint32_t) get_rand_bpf_fd();
 >  			break;
 > +#endif

I think it might be better if we wrap all of net/bpf.c in this ifdef,
and then add additional ones wherever we call bpf_gen_filter.
(Right now only two places iirc)

	Dave