From: Dave Jones <davej@codemonkey.org.uk>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Tommi Rantala <tt.rantala@gmail.com>, trinity@vger.kernel.org
Subject: Re: [PATCH 1/5] Makefile: use grep -c to avoid wc -l
Date: Tue, 7 Feb 2017 09:14:48 -0500 [thread overview]
Message-ID: <20170207141448.qw3sg6udt6rhllv3@codemonkey.org.uk> (raw)
In-Reply-To: <877f52b9ja.fsf@concordia.ellerman.id.au>
On Tue, Feb 07, 2017 at 09:05:45PM +1100, Michael Ellerman wrote:
> Tommi Rantala <tt.rantala@gmail.com> writes:
>
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index b93fc3a..16fafe8 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2,7 +2,7 @@ VERSION="1.8pre"
> >
> > INSTALL_PREFIX ?= $(DESTDIR)
> > INSTALL_PREFIX ?= $(HOME)
> > -NR_CPUS := $(shell grep ^processor /proc/cpuinfo | /usr/bin/wc -l)
> > +NR_CPUS := $(shell grep -c ^processor /proc/cpuinfo)
>
> Or you could just use nproc(1) ?
Is that in ancient coreutils from crusty old enterprise distros ?
Judging by user reports, I think we need to support back as far as
RHEL6 for now.
> It's in coreutils, but maybe that's not sufficiently portable?
Portability to non-Linux OS's hasn't been a concern so far.
I had 1-2 people email me about BSD support but the patches they've sent
have been about 1% of the work actually necessary so I've just rejected
them.
It's way easier to just extend iknowthis (or possibly syzkaller)
than to retrofit it into Trinity at this point.
I admit to having a morbid curiousity to know just how well the various
BSD's would hold up under a targetted fuzzing run, but the likelyhood of
me finding time to work on it, or even support it, is practically nil.
Dave
next prev parent reply other threads:[~2017-02-07 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 15:53 [PATCH 1/5] Makefile: use grep -c to avoid wc -l Tommi Rantala
2017-02-05 15:53 ` [PATCH 2/5] Makefile: use findstring to check if we are building in development mode Tommi Rantala
2017-02-05 15:53 ` [PATCH 3/5] Makefile: improve build time with immediate variables Tommi Rantala
2017-02-05 15:53 ` [PATCH 4/5] Makefile: -Werror also for gcc 6.x Tommi Rantala
2017-02-05 15:53 ` [PATCH 5/5] btrfs/ioctl.h is not really needed Tommi Rantala
2017-02-07 10:05 ` [PATCH 1/5] Makefile: use grep -c to avoid wc -l Michael Ellerman
2017-02-07 14:14 ` Dave Jones [this message]
2017-02-08 3:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207141448.qw3sg6udt6rhllv3@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=mpe@ellerman.id.au \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).