From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>,
Simon Glass <sjg@chromium.org>
Cc: u-boot-amlogic@groups.io, Igor Opaniuk <igor.opaniuk@gmail.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tom Rini <trini@konsulko.com>, "Andrew F. Davis" <afd@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Mario Six <mario.six@gdsys.cc>,
u-boot@lists.denx.de, rockosov@gmail.com,
kernel@salutedevices.com
Subject: Re: [PATCH v3 2/6] treewide: bcb: move ab_select command to bcb subcommands
Date: Thu, 17 Oct 2024 13:43:31 +0200 [thread overview]
Message-ID: <874j5b2bvg.fsf@baylibre.com> (raw)
In-Reply-To: <20241016154832.nqlyspranlrsl6l7@CAB-WSD-L081021>
Hi Dmitry,
On mer., oct. 16, 2024 at 18:48, Dmitry Rokosov <ddrokosov@salutedevices.com> wrote:
[...]
>> > ```
>>
>> Long help should use U_BOOT_LONGHELP, we normally handle this with
>> #ifdef - see cmd/bootflow.c for example
>
> Thank you for pointing me to U_BOOT_LONGHELP. I have redesigned
> cmd/bcb.c to utilize the U_BOOT_LONGHELP(), U_BOOT_CMD_WITH_SUBCMDS(),
> and U_BOOT_SUBCMD_MKENT() functions. As a result, a significant amount
> of command management code has been removed from cmd/bcb.c, making it
> look much more compact.
>
> To be honest, I think I missed the minargs parameter in
> U_BOOT_CMD_WITH_SUBCMDS(). Including minargs would enable us to avoid
> checking argc for a minimum value in the each subcmd callback and
> returning CMD_RET_USAGE in case of any errors.
>
> Anyway, I will prepare v5 version with refactored cmd/bcb.c to
> U_BOOT_LONGHELP usage.
Thank you for your patience with all the back and forth on this. Looking
forward to v5 !
Cheers
Mattijs
>
> --
> Thank you,
> Dmitry
next prev parent reply other threads:[~2024-10-17 11:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 20:18 [PATCH v3 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes Dmitry Rokosov
2024-10-08 20:18 ` [PATCH v3 1/6] include/android_ab: move ab_select_slot() documentation to @ notation Dmitry Rokosov
2024-10-08 20:18 ` [PATCH v3 2/6] treewide: bcb: move ab_select command to bcb subcommands Dmitry Rokosov
2024-10-09 1:56 ` Simon Glass
2024-10-11 13:30 ` Mattijs Korpershoek
[not found] ` <17FD691FA1477948.8140@groups.io>
2024-10-11 14:20 ` Mattijs Korpershoek
2024-10-11 18:00 ` Dmitry Rokosov
2024-10-12 8:49 ` Mattijs Korpershoek
2024-10-14 20:38 ` Dmitry Rokosov
2024-10-14 21:06 ` Simon Glass
2024-10-15 12:10 ` Mattijs Korpershoek
2024-10-15 13:26 ` Dmitry Rokosov
2024-10-15 15:26 ` Mattijs Korpershoek
2024-10-16 14:06 ` Dmitry Rokosov
2024-10-17 11:41 ` Mattijs Korpershoek
2024-10-15 14:42 ` Dmitry Rokosov
2024-10-15 15:27 ` Simon Glass
2024-10-16 15:48 ` Dmitry Rokosov
2024-10-17 11:43 ` Mattijs Korpershoek [this message]
2024-10-08 20:18 ` [PATCH v3 3/6] cmd: bcb: change strcmp() usage style in the do_bcb_ab_select() Dmitry Rokosov
2024-10-08 20:18 ` [PATCH v3 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content Dmitry Rokosov
2024-10-09 1:57 ` Simon Glass
2024-10-09 13:26 ` Dmitry Rokosov
2024-10-09 21:13 ` Simon Glass
2024-10-10 10:20 ` Dmitry Rokosov
2024-10-10 12:17 ` Mattijs Korpershoek
[not found] ` <17FD1697482D61A4.19251@groups.io>
2024-10-11 14:22 ` Mattijs Korpershoek
2024-10-11 14:45 ` Dmitry Rokosov
2024-10-11 15:06 ` Mattijs Korpershoek
2024-10-11 14:24 ` Mattijs Korpershoek
2024-10-08 20:18 ` [PATCH v3 5/6] common: android_ab: fix slot suffix for abc block Dmitry Rokosov
2024-10-08 20:18 ` [PATCH v3 6/6] test/py: introduce test for ab_dump command Dmitry Rokosov
2024-10-09 13:28 ` [PATCH v3 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes Dmitry Rokosov
2024-10-09 14:05 ` Guillaume LA ROQUE
2024-10-09 14:49 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j5b2bvg.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=afd@ti.com \
--cc=ddrokosov@salutedevices.com \
--cc=igor.opaniuk@gmail.com \
--cc=kernel@salutedevices.com \
--cc=mario.six@gdsys.cc \
--cc=neil.armstrong@linaro.org \
--cc=rockosov@gmail.com \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox