From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alfred Manheim Date: Wed, 1 Aug 2007 21:34:57 -0500 Subject: [U-Boot-Users] MPC83xx - previous patch to set MBAR In-Reply-To: <995B09A8299C2C44B59866F6391D2635AAD0C5@zch01exm21.fsl.freescale.net> References: <20070801133056.GP3972@stusta.de> <5EACFDEA24DADE42BF109303D305A8093120A6@MAIL.clearcube.com> <20070801192009.656fc2e0.kim.phillips@freescale.com> <995B09A8299C2C44B59866F6391D2635AAD0C5@zch01exm21.fsl.freescale.net> Message-ID: <000001c7d4ad$b83a07b0$28ae1710$@rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de This was to the wrong group. Thanks for the responses and the clarification. The "needed for CodeWarrior only" part is what I suspected. Keith Mund -----Original Message----- From: linuxppc-dev-bounces+alfman=austin.rr.com@ozlabs.org [mailto:linuxppc-dev-bounces+alfman=austin.rr.com at ozlabs.org] On Behalf Of Liu Dave-r63238 Sent: Wednesday, August 01, 2007 9:15 PM To: Phillips Kim-R1AAHA; Keith Mund Cc: linuxppc-dev at ozlabs.org; u-boot-users at lists.sourceforge.net Subject: RE: [U-Boot-Users] MPC83xx - previous patch to set MBAR > > The end result simply adds a line to set MBAR to match IMMRBAR. > > > > lis r3, CFG_IMMRBAR at h > > ori r3, r3, CFG_IMMRBAR at l > > stw r3, IMMRBAR(r4) > > + mtspr MBAR, r3 > > > > Are these patches routinely added to the mainstream u-boot code? > > > > Is there any reason why this fix is not a good idea? > > > does setting MBAR really fix anything? > > MBAR doesn't live up to its name. It's a general-purpose scratch > register - the hardware doesn't do anything with it. So, wrt Kim is right. MBAR setting is added by two years ago, it is not really fix anything. I set the MBAR to be easier to use the CodeWarriror. The CodeWarrior must set the MBAR first, then it will be able to access the IMMR. Dave _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev at ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev