From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Patrice Chotard'" <patrice.chotard@foss.st.com>,
<u-boot@lists.denx.de>
Cc: "'Patrick DELAUNAY'" <patrick.delaunay@foss.st.com>,
"'U-Boot STM32'" <uboot-stm32@st-md-mailman.stormreply.com>,
"'Jonas Karlman'" <jonas@kwiboo.se>,
"'Marek Vasut'" <marex@denx.de>,
"'Quentin Schulz'" <quentin.schulz@cherry.de>,
"'Simon Glass'" <sjg@chromium.org>,
"'Tom Rini'" <trini@konsulko.com>
Subject: RE: [PATCH v2 2/2] power: regulator: replace dev_dbg() by dev_err() in regulator_post_bind()
Date: Wed, 4 Dec 2024 08:47:26 +0900 [thread overview]
Message-ID: <000101db45dd$b54ddef0$1fe99cd0$@samsung.com> (raw)
In-Reply-To: <20241203100611.354468-2-patrice.chotard@foss.st.com>
> -----Original Message-----
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> Sent: Tuesday, December 3, 2024 7:06 PM
> To: u-boot@lists.denx.de
> Cc: Patrice CHOTARD <patrice.chotard@foss.st.com>; Patrick DELAUNAY <patrick.delaunay@foss.st.com>; U-
> Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>; Jaehoon Chung <jh80.chung@samsung.com>; Jonas
> Karlman <jonas@kwiboo.se>; Marek Vasut <marex@denx.de>; Quentin Schulz <quentin.schulz@cherry.de>;
> Simon Glass <sjg@chromium.org>; Tom Rini <trini@konsulko.com>
> Subject: [PATCH v2 2/2] power: regulator: replace dev_dbg() by dev_err() in regulator_post_bind()
>
> To ease debugging, use dev_err() instead of dev_dbg() for
> alerting when regulator has nonunique value.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
>
> ---
>
> Changes in v2:
> - split initial patch into 2 commits to separate dev_dbg() and
> dev_err() migration.
>
> drivers/power/regulator/regulator-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
> index 80ea5e65d48..09567eb9dbb 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -446,7 +446,7 @@ static int regulator_post_bind(struct udevice *dev)
> }
>
> if (!regulator_name_is_unique(dev, uc_pdata->name)) {
> - dev_dbg(dev, "'%s' has nonunique value: '%s\n",
> + dev_err(dev, "'%s' has nonunique value: '%s\n",
> property, uc_pdata->name);
> return -EINVAL;
> }
> --
> 2.25.1
next prev parent reply other threads:[~2024-12-03 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241203101026epcas1p333452efbf04c91a651dc4de99877dbb8@epcas1p3.samsung.com>
2024-12-03 10:06 ` [PATCH v2 1/2] power: regulator: replace some debug() by dev_dbg() Patrice Chotard
2024-12-03 10:06 ` [PATCH v2 2/2] power: regulator: replace dev_dbg() by dev_err() in regulator_post_bind() Patrice Chotard
2024-12-03 10:17 ` Quentin Schulz
2024-12-03 23:47 ` Jaehoon Chung [this message]
2024-12-03 10:17 ` [PATCH v2 1/2] power: regulator: replace some debug() by dev_dbg() Quentin Schulz
2024-12-03 23:44 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101db45dd$b54ddef0$1fe99cd0$@samsung.com' \
--to=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox