public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Joshua Watt'" <jpewhacker@gmail.com>, <u-boot@lists.denx.de>
Cc: "'Simon Glass'" <sjg@chromium.org>
Subject: RE: [PATCH v2 1/5] dm: test: Fix partition test to use mmc2
Date: Wed, 5 Jul 2023 09:16:55 +0900	[thread overview]
Message-ID: <000401d9aed6$01cf0880$056d1980$@samsung.com> (raw)
In-Reply-To: <20230703133959.3880305-2-JPEWhacker@gmail.com>



> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Joshua Watt
> Sent: Monday, July 3, 2023 10:40 PM
> To: u-boot@lists.denx.de
> Cc: Joshua Watt <JPEWhacker@gmail.com>; Simon Glass <sjg@chromium.org>
> Subject: [PATCH v2 1/5] dm: test: Fix partition test to use mmc2
> 
> d94d9844bc ("dm: part: Update test to use mmc2") attempted to make the
> test use mmc2, but the change was incomplete in that it didn't also
> change the strings that reference a specific partition. Fix these so
> that the test passes again
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  test/dm/part.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/test/dm/part.c b/test/dm/part.c
> index 35e99eeb01..d5c58d6e3f 100644
> --- a/test/dm/part.c
> +++ b/test/dm/part.c
> @@ -76,15 +76,15 @@ static int dm_test_part(struct unit_test_state *uts)
>  	test(-EINVAL, "#test1", true);
>  	test(1, "2", false);
>  	test(1, "2", true);
> -	test(-ENOENT, "1:0", false);
> -	test(0, "1:0", true);
> -	test(1, "1:1", false);
> -	test(2, "1:2", false);
> -	test(1, "1.0", false);
> -	test(0, "1.0:0", true);
> -	test(1, "1.0:1", false);
> -	test(2, "1.0:2", false);
> -	test(-EINVAL, "1#bogus", false);
> +	test(-ENOENT, "2:0", false);
> +	test(0, "2:0", true);
> +	test(1, "2:1", false);
> +	test(2, "2:2", false);
> +	test(1, "2.0", false);
> +	test(0, "2.0:0", true);
> +	test(1, "2.0:1", false);
> +	test(2, "2.0:2", false);
> +	test(-EINVAL, "2#bogus", false);
>  	test(1, "2#test1", false);
>  	test(2, "2#test2", false);
>  	ret = 0;
> --
> 2.33.0



  parent reply	other threads:[~2023-07-05  0:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 19:59 [PATCH 0/2] Fix 'mbr' command with hybrid MBR/GPT Joshua Watt
2023-06-23 19:59 ` [PATCH 1/2] disk: part: Add API to get partitions with specific driver Joshua Watt
2023-06-26  9:07   ` Simon Glass
2023-06-28 13:33     ` Joshua Watt
2023-06-29 19:09       ` Simon Glass
2023-06-23 20:00 ` [PATCH 2/2] cmd: mbr: Force DOS driver to be used for verify Joshua Watt
2023-07-03 13:39 ` [PATCH v2 0/5] Fix 'mbr' command with hybrid MBR/GPT Joshua Watt
2023-07-03 13:39   ` [PATCH v2 1/5] dm: test: Fix partition test to use mmc2 Joshua Watt
2023-07-04  2:40     ` Simon Glass
2023-07-05  0:16     ` Jaehoon Chung [this message]
2023-07-18 13:58     ` Tom Rini
2023-07-03 13:39   ` [PATCH v2 2/5] dm: test: Improve partition test error output Joshua Watt
2023-07-04  2:40     ` Simon Glass
2023-07-18 13:58     ` Tom Rini
2023-07-03 13:39   ` [PATCH v2 3/5] disk: part: Add API to get partitions with specific driver Joshua Watt
2023-07-04  2:40     ` Simon Glass
2023-07-18 13:58     ` Tom Rini
2023-07-03 13:39   ` [PATCH v2 4/5] dm: test: Add test for part_get_info_by_type Joshua Watt
2023-07-04  2:40     ` Simon Glass
2023-07-18 13:58     ` Tom Rini
2023-07-03 13:39   ` [PATCH v2 5/5] cmd: mbr: Force DOS driver to be used for verify Joshua Watt
2023-07-04  2:40     ` Simon Glass
2023-07-18 13:58     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000401d9aed6$01cf0880$056d1980$@samsung.com' \
    --to=jh80.chung@samsung.com \
    --cc=jpewhacker@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox