RE: [PATCH 17/20] mmc: rockchip_sdhci: Add support for RK3576

["Jaehoon Chung" <jh80.chung@samsung.com>]

> -----Original Message-----
> From: Heiko Stuebner <heiko@sntech.de>
> Sent: Thursday, November 21, 2024 11:27 PM
> To: sjg@chromium.org; philipp.tomsich@vrull.eu; kever.yang@rock-chips.com
> Cc: heiko@sntech.de; lukma@denx.de; seanga2@gmail.com; peng.fan@nxp.com; jh80.chung@samsung.com;
> joe.hershberger@ni.com; rfried.dev@gmail.com; jonas@kwiboo.se; quentin.schulz@cherry.de;
> detlev.casanova@collabora.com; u-boot@lists.denx.de; sebastian.reichel@collabora.com
> Subject: [PATCH 17/20] mmc: rockchip_sdhci: Add support for RK3576
>
> Add support for RK3576 to the rockchip sdhci driver.
>
> It's pretty similar to its cousins found in the RK3568 and RK3588 and the
> specific hs400-tx-tap number was taken from the vendor-u-boot.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>


Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/rockchip_sdhci.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
> index da630b9d97a..9571e7d66c9 100644
> --- a/drivers/mmc/rockchip_sdhci.c
> +++ b/drivers/mmc/rockchip_sdhci.c
> @@ -656,6 +656,14 @@ static const struct sdhci_data rk3568_data = {
>  	.hs400_txclk_tapnum = 0x8,
>  };
>
> +static const struct sdhci_data rk3576_data = {
> +	.set_ios_post = rk3568_sdhci_set_ios_post,
> +	.set_clock = rk3568_sdhci_set_clock,
> +	.config_dll = rk3568_sdhci_config_dll,
> +	.hs200_txclk_tapnum = DLL_TXCLK_TAPNUM_DEFAULT,
> +	.hs400_txclk_tapnum = 0x7,
> +};
> +
>  static const struct sdhci_data rk3588_data = {
>  	.set_ios_post = rk3568_sdhci_set_ios_post,
>  	.set_clock = rk3568_sdhci_set_clock,
> @@ -673,6 +681,10 @@ static const struct udevice_id sdhci_ids[] = {
>  		.compatible = "rockchip,rk3568-dwcmshc",
>  		.data = (ulong)&rk3568_data,
>  	},
> +	{
> +		.compatible = "rockchip,rk3576-dwcmshc",
> +		.data = (ulong)&rk3576_data,
> +	},
>  	{
>  		.compatible = "rockchip,rk3588-dwcmshc",
>  		.data = (ulong)&rk3588_data,
> --
> 2.45.2