From: "Robert Deliën" <robert.delien@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Proposed change to PL010 serial driver (fixed)
Date: Thu, 14 Dec 2006 10:07:50 +0100 [thread overview]
Message-ID: <000801c71f5f$552e99a0$dfdd9182@code1.emi.philips.com> (raw)
Hi,
Thanks to the valuable review and feedback of Daniel Hobi I have now fixed
the macro in my earlier proposed patch for the PL010 serial port driver.
This fix increases round-off accuracy of the UART_PL010_BAUD2DIVISOR macro.
Below is my original comment for this patch:
I am currently cleaning up my patch that provides ADM5120 support in U-Boot.
But before submitting it I'd like to propose a change to the PL010 serial
port driver. As far as I know, the PL010 uart is mostly used in ARM based
SoCs. It's currently implemented for big endian only. The ADM5120 is MIPS
based and has two PL010 serial ports on board. Most of the targets using the
ADM5120 are configured for little endian mode.
The patch below replaces the IO_READ and IO_WRITE macros with the readl and
writel functions from asm/io.h, the designated functions for reading from
and writing to IO, swapping endianness if necessary.
It also replaces the various bitrate macros with one macro containing a
unified bitrate calculation formula, using the newly introduced
CFG_UART_PL010_CLOCK macro. The only other target using this serial port
driver is intergratorap.h. I have backward calculated the uart clock for
this target and added it to its configuration.
With kind regards,
Robert.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial_pl010.diff
Type: application/octet-stream
Size: 4944 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061214/e2716032/attachment.obj
reply other threads:[~2006-12-14 9:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801c71f5f$552e99a0$dfdd9182@code1.emi.philips.com' \
--to=robert.delien@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox