From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE334C05027 for ; Fri, 10 Feb 2023 00:00:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 33D6E85677; Fri, 10 Feb 2023 01:00:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="ihixWCrd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E96285D3E; Fri, 10 Feb 2023 01:00:44 +0100 (CET) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C0C4E85613 for ; Fri, 10 Feb 2023 01:00:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230210000036epoutp01c2af48407129e2dde6405ca94d7c0069~CTYMgfylU2066320663epoutp01b for ; Fri, 10 Feb 2023 00:00:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230210000036epoutp01c2af48407129e2dde6405ca94d7c0069~CTYMgfylU2066320663epoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1675987236; bh=cboZSZSFP3N635SRW8aSw/BMuRtPqwuK6HDr4VTy8Hc=; h=From:To:In-Reply-To:Subject:Date:References:From; b=ihixWCrdRjuip6S9YuCDoCkOFy+COtDazDtzF6TUlrP6UixkQayR3bIG9PjLVN6ma 1mhRNAMaZw2jSz8j2ZbhX+QOx3wLWr9LI9DFVTJYN5fBv5SggpE5xG22z+VXx8FKrQ pQ2f2wiuasrN6g2oYFXa/BQ9LXfZMvhvBMWdjX34= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230210000036epcas1p186c56b14d1e65633e19b4b9a45bc24b6~CTYMF06tO0559405594epcas1p1Y; Fri, 10 Feb 2023 00:00:36 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.134]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PCYll4J3Sz4x9Q7; Fri, 10 Feb 2023 00:00:35 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id B7.79.37890.22985E36; Fri, 10 Feb 2023 09:00:34 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20230210000034epcas1p3e6b9b062d76efee30e9c1e1cd54fe677~CTYKB1HEO2038620386epcas1p3E; Fri, 10 Feb 2023 00:00:34 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230210000034epsmtrp21804e583b879621ced1e7b14d2312cba~CTYKBHBDQ1697416974epsmtrp2M; Fri, 10 Feb 2023 00:00:34 +0000 (GMT) X-AuditID: b6c32a38-bbd3aa8000029402-b0-63e58922a939 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id B4.DA.05839.22985E36; Fri, 10 Feb 2023 09:00:34 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230210000033epsmtip1f5b96f0cc9d518c7690bb76377db7457~CTYJw74L52870428704epsmtip1Q; Fri, 10 Feb 2023 00:00:33 +0000 (GMT) From: "Jaehoon Chung" To: "'Henrik Grimler'" , , , , , , <~postmarketos/upstreaming@lists.sr.ht> In-Reply-To: <20230208190421.62661-2-henrik@grimler.se> Subject: RE: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" Date: Fri, 10 Feb 2023 09:00:33 +0900 Message-ID: <000901d93ce2$b28c12a0$17a437e0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHkOZh4jCdKDKBJqoWT7EpekMFBTwGRpy3TAld6/k+ukgfgUA== Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKJsWRmVeSWpSXmKPExsWy7bCmga5S59Nkg0M3lCzeLtnFaHHxylJm i5crf7NarD1yl93i25ZtjBZv93ayW2z+/pfRgd1jdsNFFo8fre/ZPHbOusvucfTKPVaPs3d2 MHr8v7OW3aNvyyrGAPaobJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxU WyUXnwBdt8wcoIuUFMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZKqQUpOQWmBXrFibnFpXnp enmpJVaGBgZGpkCFCdkZP1feYi5YzF/x+uE69gbG0zxdjJwcEgImEhcvTWDvYuTiEBLYwSgx 5fcxNgjnE6PEldnH2EGqhAS+MUr8XmwF07HqaQdUx15GiQUt/SwQzktGifO/9zGDVLEJ6En8 X7SQGSQhInCKUeLU/tdgCU4Bc4mrLUtZQGxhgRCJ5V1NrCA2i4CqxJLXHUwgNq+ApcT5x43M ELagxMmZT8DqmQXkJba/ncMMcYaCxM+ny8B6RQScJI4fWMEMUSMiMbuzDWyxhMBCDomt93qY IBpcJI6cPc4CYQtLvDq+hR3ClpL4/G4vG0RDM6PE0iUHWSGcHkaJfw3X2SCqjCX2L50MNIkD aIWmxPpd+hBhRYmdv+cyQmzmk3j3tYcVpERCgFeio00IokRF4tLrl0wwu+4++c8KYXtIPH1z k30Co+IsJH/OQvLnLCT/zEJYvICRZRWjWGpBcW56arFhgQk8vpPzczcxgtOrlsUOxrlvP+gd YmTiYDzEKMHBrCTC+33i42Qh3pTEyqrUovz4otKc1OJDjKbAkJ/ILCWanA9M8Hkl8YYmlgYm ZkbGJhaGZoZK4rzitieThQTSE0tSs1NTC1KLYPqYODilGpiS/x5Z7XNPfd2HqcEf7mbOyJgt +ev9ssSAU6JdM5cWzpNYc2HGz2q7m07KQY8/6fXY6+903RJZb6cWOGGH07a/TE8jlsRfvLpu U3GF+jFt2zsfChtbNTxUhH5MN+0uq7PMuNicc1Y30OL83qNV747fUNr0d/Oy3yVMm3aZ8b5m P3NJPDE1d8lC2fDijzoXmp5MlIgqeTU1SqBfa8Pi6RU6Xwt/xi9XFZIVbNomGRKrozXv2WqJ O8uEvj4XniR0Jv1OkXNYVqDJ/RMfo84n3n4VvIafp3aWjfqugDK3lTst67OKZ7kYRCmqO73K zW2bPclOVePo2Y5fpoHV91ITHI6nz2krmie1Z++mFRMVD8kpsRRnJBpqMRcVJwIAypy7HDgE AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42LZdlhJTlep82mywYxuTou3S3YxWly8spTZ 4uXK36wWa4/cZbf4tmUbo8XbvZ3sFpu//2V0YPeY3XCRxeNH63s2j52z7rJ7HL1yj9Xj7J0d jB7/76xl9+jbsooxgD2KyyYlNSezLLVI3y6BK+PnylvMBYv5K14/XMfewHiap4uRk0NCwERi 1dMO9i5GLg4hgd2MEouXX2KGSEhJfH46la2LkQPIFpY4fLgYouY5o8TZe5vZQGrYBPQk/i9a yAySEBG4xCjxcup9VoiqzYwSL2a2MYJUcQqYS1xtWcoCYgsLBEk8WrcaLM4ioCqx5HUHE4jN K2Apcf5xIzOELShxcuYTFpDNzEAb2jaClTMLyEtsfzsH6jgFiZ9Pl7GC2CICThLHD6xghqgR kZjd2cY8gVFoFpJJsxAmzUIyaRaSjgWMLKsYJVMLinPTc4sNCwzzUsv1ihNzi0vz0vWS83M3 MYJjSUtzB+P2VR/0DjEycTAeYpTgYFYS4f0+8XGyEG9KYmVValF+fFFpTmrxIUZpDhYlcd4L XSfjhQTSE0tSs1NTC1KLYLJMHJxSDUw5035FBx2eyDvjKv/ipk/7g6rDam4cT36/SKen/5fl 3QkenDe2XpEPTvp4wtb3JJ/1vvwT5S8sOxYplT/freadfldB7NjjaTMly9clcM67f1q23mtO kcTuu+1Gtu/M5bxttCcnpojL8slKzOzr3qwtw3ChROUOf3fihW1mOkFl8geP7qw7sUDSVWlJ rsLVZRUFHtFTptWvebTYp/VVVlbIwh3Vx01kuj+z71Nr3MLGHO7Z8II7M/bu+tXBzT6KGfG6 z/atzH7ROc/rgmmioOWO4H7H0Kea/pZuj90PPVz+p1eWT+H85v0fluuuecsZ8KCl+vu3aecM ArpW21S/5hC/Fn254KN07+t77Z4/tiixFGckGmoxFxUnAgCiAgnPFAMAAA== X-CMS-MailID: 20230210000034epcas1p3e6b9b062d76efee30e9c1e1cd54fe677 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230208190520epcas1p371eade560ed81d9e53d51c6f88585e7b References: <20230208190421.62661-1-henrik@grimler.se> <20230208190421.62661-2-henrik@grimler.se> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, > -----Original Message----- > From: U-Boot On Behalf Of Henrik Grimler > Sent: Thursday, February 9, 2023 4:04 AM > To: joost@diskos.nl; jh80.chung@gmail.com; andy.wu@sony.com; sjg@chromium.org; > m.szyprowski@samsung.com; u-boot@lists.denx.de; ~postmarketos/upstreaming@lists.sr.ht > Cc: Henrik Grimler > Subject: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" > > This reverts commit a034ec06ff1d558bbe11d5ee05edbb4de3ee2215. > > Commit 4a3ea75de4c5 ("Revert "mmc: sdhci: set to INT_DATA_END when > there are data"") reverted the alternative fix that was added for > Exynos 4 devices, causing an error when trying to boot from an sdcard: > > <...> > Loading Environment from MMC... sdhci_send_command: Timeout for status update! > mmc fail to send stop cmd > <...> Thanks for sharing issue. I will check this on Exynos Board. Frankly, I hope not to re-add QUIRK. Because it was verified that it was working fine without SDHCI_QUIKR_BROKEN_RIB. Best Regards, Jaehoon Chung > > Re-add the quirk to allow booting from sdcards again. > > Signed-off-by: Henrik Grimler > --- > drivers/mmc/s5p_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c > index dee84263c3fd..3b74feae68c7 100644 > --- a/drivers/mmc/s5p_sdhci.c > +++ b/drivers/mmc/s5p_sdhci.c > @@ -90,7 +90,7 @@ static int s5p_sdhci_core_init(struct sdhci_host *host) > host->name = S5P_NAME; > > host->quirks = SDHCI_QUIRK_NO_HISPD_BIT | SDHCI_QUIRK_BROKEN_VOLTAGE | > - SDHCI_QUIRK_32BIT_DMA_ADDR | > + SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR | > SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8; > host->max_clk = 52000000; > host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > -- > 2.30.2