[U-Boot] [PATCH 3/3] TI: DaVinci: Create configuration file for da850 EVM

[Sudhakar Rajashekhara <sudhakar.raj@ti.com>]

Hi,

On Fri, May 07, 2010 at 03:36:49, Wolfgang Denk wrote:
> Dear Sudhakar Rajashekhara,
> 
> In message <1272445230-427-1-git-send-email-sudhakar.raj@ti.com> you wrote:
> > Provides initial support for TI OMAP-L138/DA850 SoC devices
> > on a Logic PD EVM board.
> > 
> > Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > ---
> >  MAINTAINERS                |    4 +
> >  MAKEALL                    |    1 +
> >  Makefile                   |    3 +
> >  include/configs/da850evm.h |  135 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 143 insertions(+), 0 deletions(-)
> >  create mode 100644 include/configs/da850evm.h
> 
> Patches 2 and 3 should be merged into one, please.
> 

Ok, I'll merge them.

> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index a5d5835..c52803d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -758,6 +758,10 @@ Nick Thompson <nick.thompson@gefanuc.com>
> >  
> >  	da830evm	ARM926EJS (DA830/OMAP-L137)
> >  
> > +Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > +
> > +	da850evm	ARM926EJS (DA850/OMAP-L138)
> > +
> >  Albin Tonnerre <albin.tonnerre@free-electrons.com>
> 
> Please keep list sorted.
> 

Ok.

> > diff --git a/Makefile b/Makefile
> > index 393b180..0f21db6 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2913,6 +2913,9 @@ cp922_XA10_config	\
> >  cp1026_config: unconfig
> >  	@board/armltd/integrator/split_by_variant.sh cp $@
> >  
> > +da850evm_config:	unconfig
> > +	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
> > +
> >  da830evm_config:	unconfig
> >  	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
> 
> Please keep list sorted, and use just a single entry, i. e.:
> 

Ok.

> 	da830evm_config	\
> 	da850evm_config:	unconfig
> 		@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
> 
> > diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
> > new file mode 100644
> > index 0000000..2fcc76d
> > --- /dev/null
> > +++ b/include/configs/da850evm.h
> ...
> > +/*
> > + * Memory Info
> > + */
> > +#define CONFIG_SYS_MALLOC_LEN	(0x10000 + 1*1024*1024) /* malloc() len */
> > +#define CONFIG_SYS_GBL_DATA_SIZE	128 /* reserved for initial data */
> > +#define PHYS_SDRAM_1		DAVINCI_DDR_EMIF_DATA_BASE /* DDR Start */
> > +#define PHYS_SDRAM_1_SIZE	(64 << 20) /* SDRAM size 64MB */
> > +#define CONFIG_SYS_MEMTEST_START	PHYS_SDRAM_1 + 0x2000000 /* memtest start addr */
> > +#define CONFIG_SYS_MEMTEST_END 	(PHYS_SDRAM_1 + 0x2000000 + 16*1024*1024) /* 16MB test */
> 
> Line too long.
> 

I'll address the review comments and will submit the updated version.

Thanks,
Sudhakar