From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994F7C433FE for ; Tue, 5 Oct 2021 13:42:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8C506117A for ; Tue, 5 Oct 2021 13:42:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B8C506117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2C49B81468; Tue, 5 Oct 2021 15:42:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="u5gNGoJ0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F3C882A01; Tue, 5 Oct 2021 15:42:02 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 869CB81E14 for ; Tue, 5 Oct 2021 15:41:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=491232a075=patrick.delaunay@foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19592RQo032039; Tue, 5 Oct 2021 15:41:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : references : in-reply-to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=selector1; bh=Pbkq2ugjUXtJPVrx5Lh7E9K15gLSfBn2Z/zZ21kna2g=; b=u5gNGoJ0zN9pTQnAsa+tqQ8U59FvyE1kmjBE4rVCpdJlVhgfgtsIqsX3Q2bhkuZZyHc3 qSVG8ZnxL1/q9zVGRcxrr1ZMJWQ67vm1S6dSiOTBJAJofjUgyLcmCjqGWvwlpS6n+M1F BmmaUx180mBlkOk3V+ulleRsg4RIevd94qIMM1TrTumYcw6onNdAzSF2riSDe5j/ZPUh JEoSITQyEfB9tx0NqT4QPOKKgYD3SKUAoj8A8RisjZhHBF3ACSy4Cc22CdA72+vIT4ZS GDrP2V3LMMzzTQNaw+c+7sAQCvthAyCDR2bX7F1Cxyop0/eaSnAvS0/g3WirEg9cQKiI iQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bgdt9ucpn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Oct 2021 15:41:57 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8F2BF100034; Tue, 5 Oct 2021 15:41:56 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7631F22D61F; Tue, 5 Oct 2021 15:41:56 +0200 (CEST) Received: from LMECWL0930 (10.75.127.51) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 15:41:55 +0200 From: To: 'Marek Vasut' , CC: 'Lukasz Majewski' References: <20211005124020.444967-1-marex@denx.de> <000f01d7b9e7$92c72e70$b8558b50$@foss.st.com> <04c5658f-f5d9-5a1d-5521-a65542600d34@denx.de> In-Reply-To: <04c5658f-f5d9-5a1d-5521-a65542600d34@denx.de> Subject: RE: [PATCH v2] dfu: dfu_sf: Add support for multiple flashes Date: Tue, 5 Oct 2021 15:41:55 +0200 Message-ID: <001801d7b9ee$c3665ea0$4a331be0$@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: fr Thread-Index: AQGKLBhG5vxCplxCD2ljouVD+9bgTwHVbvODAcxYAS6sQnYnkA== msip_labels: MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Enabled=true; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SetDate=2021-10-05T13:41:54Z; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Method=Standard; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Name=23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ActionId=77d98076-0c41-4fa5-9a83-e575ee1e0d7f; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ContentBits=2 X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-05_02,2021-10-04_01,2020-04-07_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, ST Restricted > -----Original Message----- > From: Marek Vasut > Sent: mardi 5 octobre 2021 15:33 > To: patrick.delaunay@foss.st.com; u-boot@lists.denx.de > Cc: 'Lukasz Majewski' > Subject: Re: [PATCH v2] dfu: dfu_sf: Add support for multiple flashes > > On 10/5/21 2:50 PM, patrick.delaunay@foss.st.com wrote: > > Hi Marek, > > > > > > ST Restricted > > > >> -----Original Message----- > >> From: U-Boot On Behalf Of Marek Vasut > >> Sent: mardi 5 octobre 2021 14:40 > >> To: u-boot@lists.denx.de > >> Cc: Marek Vasut ; Lukasz Majewski > >> Subject: [PATCH v2] dfu: dfu_sf: Add support for multiple flashes > >> > >> Add dfu_alt_info option which allows specifying multiple SPI flashes > >> as an > > alt info. > >> The syntax is as follows: > >> > >> altname sf bus:cs[:speed[:mode]] > >> > >> Example: > >> dfu_alt_info=qspi0 sf 0:0;qspi1 sf 0:1 > >> > >> Signed-off-by: Marek Vasut > >> Cc: Lukasz Majewski > >> --- > >> V2: Fix device string parsing in all cases > >> --- > >> drivers/dfu/dfu_sf.c | 31 ++++++++++++++++++++++++------- > >> 1 file changed, 24 insertions(+), 7 deletions(-) > >> > >> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c index > >> b72493ced86..6d33497990a 100644 > >> --- a/drivers/dfu/dfu_sf.c > >> +++ b/drivers/dfu/dfu_sf.c > >> @@ -168,30 +168,46 @@ static struct spi_flash *parse_dev(char > >> *devstr) > > int > >> dfu_fill_entity_sf(struct dfu_entity *dfu, char *devstr, char *s) { > >> char *st; > >> - char *devstr_bkup = strdup(devstr); > >> - > >> - dfu->data.sf.dev = parse_dev(devstr_bkup); > >> - free(devstr_bkup); > >> - if (!dfu->data.sf.dev) > >> - return -ENODEV; > >> > >> dfu->dev_type = DFU_DEV_SF; > >> - dfu->max_buf_size = dfu->data.sf.dev->sector_size; > >> > >> st = strsep(&s, " "); > >> if (!strcmp(st, "raw")) { > >> + char *devstr_bkup = strdup(devstr); > >> + dfu->data.sf.dev = parse_dev(devstr_bkup); > >> + free(devstr_bkup); > >> + if (!dfu->data.sf.dev) > >> + return -ENODEV; > >> + > >> dfu->layout = DFU_RAW_ADDR; > >> + dfu->max_buf_size = dfu->data.sf.dev->sector_size; > >> dfu->data.sf.start = hextoul(s, &s); > >> s++; > >> dfu->data.sf.size = hextoul(s, &s); > >> + } else if (!strcmp(st, "sf")) { > >> + st = strsep(&s, " "); > >> + dfu->data.sf.dev = parse_dev(st); > >> + if (!dfu->data.sf.dev) > >> + return -ENODEV; > >> + > >> + dfu->layout = DFU_RAW_ADDR; > >> + dfu->max_buf_size = dfu->data.sf.dev->sector_size; > >> + dfu->data.sf.start = 0; > >> + dfu->data.sf.size = dfu->data.sf.dev->size; > >> } else if (CONFIG_IS_ENABLED(DFU_SF_PART) && > >> (!strcmp(st, "part") || !strcmp(st, "partubi"))) { > >> + char *devstr_bkup = strdup(devstr); > >> char mtd_id[32]; > >> struct mtd_device *mtd_dev; > >> u8 part_num; > >> struct part_info *pi; > >> int ret, dev, part; > >> > >> + dfu->data.sf.dev = parse_dev(devstr_bkup); > >> + free(devstr_bkup); > >> + if (!dfu->data.sf.dev) > >> + return -ENODEV; > >> + > >> dfu->layout = DFU_RAW_ADDR; > >> > >> dev = dectoul(s, &s); > >> @@ -208,6 +224,7 @@ int dfu_fill_entity_sf(struct dfu_entity *dfu, > >> char > > *devstr, > >> char *s) > >> printf("Could not locate '%s'\n", mtd_id); > >> return -1; > >> } > >> + dfu->max_buf_size = dfu->data.sf.dev->sector_size; > >> dfu->data.sf.start = pi->offset; > >> dfu->data.sf.size = pi->size; > >> if (!strcmp(st, "partubi")) > >> -- > >> 2.33.0 > > > > The same use case can be supported with mtd backend > > > > https://elixir.bootlin.com/u-boot/latest/source/doc/usage/dfu.rst > > > > > > U-Boot> env set dfu_alt_info \ > > "mtd nor0=spl part 1;u-boot part 2;u-boot-env part 3&"\ > > "mtd nand0=UBI partubi 1" > > Does it work for multiple SPI NORs at the same time ? If it is support on mtd side, yes it is supported in dfu... And I think it is supported now (with u-class UCLASS_SPI_FLASH). I need to check.deeper Patrick