From: Michal Simek <monstr@seznam.cz>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/4] emaclite
Date: Mon, 6 Aug 2007 22:00:01 +0200 [thread overview]
Message-ID: <001d01c7d864$5fedaed0$0500a8c0@monstrone> (raw)
In-Reply-To: 20070805200517.594F8353DB4@atlas.denx.de
> Please clean up coding style (indentation, trailing white space,
> etc.). Also please use variable and function names according to
> coding style rules, i. e. "do not use cute names like
> ThisVariableIsATemporaryCounter." ... "mixed-case names are frowned
> upon".
>
I fix cute name from emac drivers but I think you have cute code in your
code too.
You can see net/net.c file and following functions.
void NetReceive
ushort getenv_VLAN
IPaddr_t getenv_IPaddr
print_IPaddr
ushort string_to_VLAN
I think mixed-case names are really frowned.
Best regards,
Michal Simek
next prev parent reply other threads:[~2007-08-06 20:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 13:38 [U-Boot-Users] Microblaze: PULL request Michal Simek
2007-08-05 14:47 ` Grant Likely
2007-08-05 14:52 ` Grant Likely
2007-08-05 15:13 ` Michal Simek
2007-08-05 16:12 ` Grant Likely
2007-08-05 16:34 ` Michal Simek
2007-08-05 18:56 ` [U-Boot-Users] [PATCH 1/4] emac Michal Simek
2007-08-05 20:07 ` Wolfgang Denk
2007-08-06 20:11 ` Michal Simek
2007-08-05 22:28 ` Grant Likely
2007-08-05 18:56 ` [U-Boot-Users] [PATCH 2/4] emaclite Michal Simek
2007-08-05 20:05 ` Wolfgang Denk
2007-08-06 20:00 ` Michal Simek [this message]
2007-08-06 20:54 ` Wolfgang Denk
2007-08-05 18:56 ` [U-Boot-Users] [PATCH 3/4] microblaze changes Michal Simek
2007-08-05 20:08 ` Wolfgang Denk
2007-08-05 18:56 ` [U-Boot-Users] [PATCH 4/4] romfs Michal Simek
2007-08-05 20:38 ` Wolfgang Denk
2007-08-05 20:01 ` [U-Boot-Users] Microblaze: PULL request Wolfgang Denk
2007-08-05 22:25 ` Grant Likely
2007-08-05 22:27 ` Wolfgang Denk
2007-08-05 22:32 ` Grant Likely
2007-08-06 17:03 ` Michal Simek
2007-08-05 19:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01c7d864$5fedaed0$0500a8c0@monstrone' \
--to=monstr@seznam.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox