From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 6 Aug 2007 22:00:01 +0200 Subject: [U-Boot-Users] [PATCH 2/4] emaclite References: <20070805200517.594F8353DB4@atlas.denx.de> Message-ID: <001d01c7d864$5fedaed0$0500a8c0@monstrone> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Please clean up coding style (indentation, trailing white space, > etc.). Also please use variable and function names according to > coding style rules, i. e. "do not use cute names like > ThisVariableIsATemporaryCounter." ... "mixed-case names are frowned > upon". > I fix cute name from emac drivers but I think you have cute code in your code too. You can see net/net.c file and following functions. void NetReceive ushort getenv_VLAN IPaddr_t getenv_IPaddr print_IPaddr ushort string_to_VLAN I think mixed-case names are really frowned. Best regards, Michal Simek