From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Samuelsson Date: Wed, 15 Aug 2007 13:40:12 +0200 Subject: [U-Boot-Users] [GIT PULL] [ARM] Please pull fromgit://denx.de/git/u-boot-arm.git References: <000101c7de92$7fb2e350$821ba8c0@Emea.Arm.com> Message-ID: <002c01c7dfdb$280ab250$dcc4af0a@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > >> -----Original Message----- >> From: wd at denx.de [mailto:wd at denx.de] >> Sent: 14 August 2007 17:10 >> To: Peter Pearse >> Cc: u-boot-users at lists.sourceforge.net; Ulf Samuelsson >> Subject: Re: [GIT PULL] [ARM] Please pull from >> git://denx.de/git/u-boot-arm.git >> >> Dear Peter, >> >> in message <000001c7de84$ee21a460$821ba8c0@Emea.Arm.com> you wrote: >> > >> > Please pull from git://denx.de/git/u-boot-arm.git >> > >> > It (actually) contains the following changes from Ulf - >> next time the >> > commit messages will match the CHANGELOG entries...... >> > >> > Add MACH_TYPE records for several AT91 boards >> > Merge to two at45.c files into a common file and split to >> at45.c and spi.c >> > Fix spelling error in DM9161 PHY Support >> > Initialize at91rm9200 board (and set LED) >> > Add PIO control for at91rm9200dk LEDs and Mux. >> > Change dataflash partition boundaries to be compatible with Linux >> > 2.6 >> > >> > Signed-off-by: Peter Pearse >> > Signed-off-by: Ulf Samuelsson >> > >> The following issues need to be addressed: >> >> >> include/led.h => seems specific to the at91rm9200dk board only, >> please move to board directory. Also, the calls to >> these functions should be handled without #ifdef's >> in common code. Either use existing functions hooks, >> or weak references. Please explain further. What is a weak reference? Which hooks? >> >> drivers/at45.c => has coding style issues - indentation of long, >> wrapped around lines is broken. >> >> cpu/arm920t/start.S => I'm surprised to see a lot of intialization >> code has now been added to the "reset" entry point. >> Is this by accident, or am I missing something? The changes are there to allow you to boot from a dataflash. A bootstrap will initialize the SDRAM and copy from the dataflash (or NAND flash) IIRC: The code avoids reinitialization of stuff which will crash U-Boot. (And sets the LED) >> include/config_cmd_all.h: "CONFIG_CMD_MUX" is a pretty generic name, >> while here it is used for a board or CPU specific >> feature only. I suggest you rename this into >> something which has a "AT91" in the name, like >> "CONFIG_CMD_AT91_SPIMUX" or so. >> >> Thanks again. >> >> Best regards, >> >> Wolfgang Denk >> Best Regards Ulf Samuelsson