public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] Pre-loader for the avnet5282 board
@ 2006-03-15  7:17 Daniel Alomar
  2006-03-15 15:06 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Alomar @ 2006-03-15  7:17 UTC (permalink / raw)
  To: u-boot

Hi,

This patch add a pre-loader for the avnet5282 board.

Regards,

Daniel Alomar i Claramonte
Research & Development Electronic Dept.
SERRA SOLDADURA, S.A.
WEB Site: http://www.serrasold.com
Knowledge Site: http://serratron.serrasold.com 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bdm-uboot1.1.4-avnet5282.patch.tar.bz2
Type: application/octet-stream
Size: 17024 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060315/9f6d4534/attachment.obj 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot-Users] Pre-loader for the avnet5282 board
  2006-03-15  7:17 [U-Boot-Users] Pre-loader for the avnet5282 board Daniel Alomar
@ 2006-03-15 15:06 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2006-03-15 15:06 UTC (permalink / raw)
  To: u-boot

In message <002d01c64800$80393330$091a1bac@serra.es> you wrote:
> 
> This patch add a pre-loader for the avnet5282 board.


Many filkes of this code do not cointain  any  Copyright  statements,
and  none  of  them  has  any indication about which license applies.
Before we can add any code it must be clear that it comes with a  GPL
compatible license.

Also, this code duplicates a  lot  of  existing  functionality,  like
serial  drivers  and  all  this.  Also  some  header  files look like
duplicates of existing ones. This is not  acceptable.  Please  re-use
the existing code.

Your code also violates the  Coding  Style  requirements  in  several
aspects. You have to clean up your code.

Make sure that all files are actually text files, i. e. all lines and
with a newline character.

Finally, scripts like your "gdbinit.load", "gdbinit.reset" etc.  have
no place in this code. Pleas remove these.


Sorry, I have to reject this patch.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A consultant is a person who borrows your watch, tells you what  time
it is, pockets the watch, and sends you a bill for it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-03-15 15:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-15  7:17 [U-Boot-Users] Pre-loader for the avnet5282 board Daniel Alomar
2006-03-15 15:06 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox