public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dimitar Penev <dpn@switchfin.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add PR1 Appliance - ISDN PRI board
Date: Sat, 19 Nov 2011 17:18:16 +0200	[thread overview]
Message-ID: <003901cca6ce$76650ef0$2901a8c0@dpn> (raw)
In-Reply-To: 201111190042.52468.vapier@gentoo.org

Hi Mike,

Thank you for the review.

I am attaching the updated patch bellow.

Few comments in a reply to your remarks/questions.

-----------------------------------------------------------------------------------------------
>> +void board_reset(void)
>> +{
>> + /* workaround for weak pull ups on ssel */
>> + if (CONFIG_BFIN_BOOT_MODE == BFIN_BOOT_SPI_MASTER)
>> +  bfin_reset_boot_spi_cs(GPIO_PF10);
>> +}
>
>do you actually have this problem in the hardware ?  or is this just left 
>over
>from copying the old bf537 file ?
PR1 Appliance seems to boot from SPI FLASH properly without the 
board_reset().

  reply	other threads:[~2011-11-19 15:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 22:49 [U-Boot] [PATCH] Add PR1 Appliance - ISDN PRI board Dimitar Penev
2011-11-19  5:42 ` Mike Frysinger
2011-11-19 15:18   ` Dimitar Penev [this message]
2011-11-19 20:17     ` Mike Frysinger
2011-11-20 20:24       ` Dimitar Penev
2011-11-25 20:55         ` Mike Frysinger
2011-11-25 21:54           ` Dimitar Penev
2011-11-25 22:08             ` Mike Frysinger
2011-11-25 23:40               ` Dimitar Penev
2012-01-08  9:24 ` [U-Boot] [PATCH v2] Blackfin: pr1: new board port Mike Frysinger
2012-01-09 17:16   ` Dimitar Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003901cca6ce$76650ef0$2901a8c0@dpn' \
    --to=dpn@switchfin.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox