From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Hamman <joe.hamman@embeddedspecialties.com>
Date: Tue, 31 Jul 2007 12:18:45 -0500
Subject: [U-Boot-Users] [PATCH 2/2] Add support for SBC8641D
In-Reply-To: <46AF56D7.4090500@qstreams.com>
References: <1185894029.28101.21.camel@server> <46AF56D7.4090500@qstreams.com>
Message-ID: <004401c7d396$da566a40$6e00a8c0@ESIDT>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: Ben Warren [mailto:bwarren at qstreams.com]
> Sent: Tuesday, July 31, 2007 10:36 AM
> To: joe.hamman at embeddedspecialties.com
> Cc: u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH 2/2] Add support for SBC8641D
> 
> Joe Hamman wrote:
> <snip>
> > +
> > +/*
> > + * Environment Configuration
> > + */
> > +
> > +/* The mac addresses for all ethernet interface */
> > +#if defined(CONFIG_TSEC_ENET)
> > +#define CONFIG_ETHADDR   00:E0:0C:00:00:01
> > +#define CONFIG_ETH1ADDR  00:E0:0C:00:01:FD
> > +#define CONFIG_ETH2ADDR  00:E0:0C:00:02:FD
> > +#define CONFIG_ETH3ADDR  00:E0:0C:00:03:FD
> > +#endif
> >
> If you're going to default MAC addresses (which IMHO is a bad idea),
> they should be private ones (i.e. bit 41 is set).  The ones you've
> listed belong to somebody (or more likely some faceless organization).
> It would be better to leave these out and make the user program them at
> board bring-up.
> 
> regards,
> Ben

Good idea.  I'll set them to private and repost.  I forgot to copy
u-boot-patches & jdl.

Thanks,
Joe