From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin KUMAR <vipin.kumar@st.com>
Date: Tue, 5 Jan 2010 09:23:16 +0530
Subject: [U-Boot] [PATCH 3/9] nand driver support for SPEAr SoCs
In-Reply-To: <20100104230622.GA24836@loki.buserror.net>
References: <1260955110-5656-1-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-2-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-3-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-4-git-send-email-vipin.kumar@st.com>
	<20100104230622.GA24836@loki.buserror.net>
Message-ID: <004401ca8dba$9cee3210$d6ca9630$@kumar@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Scott,

> 
> Acked-by: Scott Wood <scottwood@freescale.com>
> 
> Some of the whitespace is a bit inconsistent, though:
> 
> > +int spear_nand_init(struct nand_chip *nand)
> > +{
> > +	writel(FSMC_DEVWID_8 | FSMC_DEVTYPE_NAND | FSMC_ENABLE |
> FSMC_WAITON,
> > +			&fsmc_regs_p->genmemctrl_pc);
> > +	writel(readl(&fsmc_regs_p->genmemctrl_pc) | FSMC_TCLR_1 |
> FSMC_TAR_1,
> > +			&fsmc_regs_p->genmemctrl_pc);
> 
> Here you continue with two tabs...
>

Thanks for pointing out. I would correct this in next revision of
patch-set

> > +	writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> > +		       &fsmc_regs_p->genmemctrl_comm);
> > +	writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> > +		       &fsmc_regs_p->genmemctrl_attrib);
> 
> ...and here with one tab plus 7 spaces.
> 
> > +	nand->ecc.layout  = &spear_nand_ecclayout;
> 
> There's an extra space before '=' here.
> 

Corrected.

Thanks for reviewing

Best Regards
Vipin