From: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] da830: Move common code out of da830evm.c file
Date: Tue, 1 Jun 2010 15:48:49 +0530 [thread overview]
Message-ID: <004601cb0173$d3738060$7a5a8120$@raj@ti.com> (raw)
In-Reply-To: <20100601100139.3AD1FAFC6B3@gemini.denx.de>
Hi,
On Tue, Jun 01, 2010 at 15:31:39, Wolfgang Denk wrote:
> Dear Sudhakar Rajashekhara,
>
> In message <1275383152-31122-1-git-send-email-sudhakar.raj@ti.com> you wrote:
> > TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137
> > in many aspects. So instead of repeating the same code in
> > multiple files, move the common code to a different file
> > and call those functions from the respective da830/da850
> > files.
> >
> > Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > Acked-by: Nick Thompson <nick.thompson@ge.com>
> > Acked-by: Ben Gardiner <bengardiner@nanometrics.ca>
> > ---
> > Since v1:
> > Added irq_init declaration in misc.h to avoid compiler warning.
>
> This patch causes the following compiler warning for me:
>
> -> ./MAKEALL da830evm da850evm
> Configuring for da830evm board...
> da830evm.c:124: warning: missing braces around initializer
> da830evm.c:124: warning: (near initialization for 'lpsc[0]')
>
> 122
> 123 static const struct lpsc_resource lpsc[] = {
> 124 DAVINCI_LPSC_AEMIF, /* NAND, NOR */
> 125 DAVINCI_LPSC_SPI0, /* Serial Flash */
> 126 DAVINCI_LPSC_EMAC, /* image download */
> 127 DAVINCI_LPSC_UART2, /* console */
> 128 DAVINCI_LPSC_GPIO,
> 129 };
>
I'll fix this and re-submit the patch.
Thanks,
Sudhakar
prev parent reply other threads:[~2010-06-01 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 9:05 [U-Boot] [PATCH v2] da830: Move common code out of da830evm.c file Sudhakar Rajashekhara
2010-06-01 10:01 ` Wolfgang Denk
2010-06-01 10:18 ` Sudhakar Rajashekhara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601cb0173$d3738060$7a5a8120$@raj@ti.com' \
--to=sudhakar.raj@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox