From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
Date: Tue, 1 Jun 2010 15:48:49 +0530
Subject: [U-Boot] [PATCH v2] da830: Move common code out of da830evm.c
	file
In-Reply-To: <20100601100139.3AD1FAFC6B3@gemini.denx.de>
References: <1275383152-31122-1-git-send-email-sudhakar.raj@ti.com>
	<20100601100139.3AD1FAFC6B3@gemini.denx.de>
Message-ID: <004601cb0173$d3738060$7a5a8120$@raj@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Tue, Jun 01, 2010 at 15:31:39, Wolfgang Denk wrote:
> Dear Sudhakar Rajashekhara,
> 
> In message <1275383152-31122-1-git-send-email-sudhakar.raj@ti.com> you wrote:
> > TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137
> > in many aspects. So instead of repeating the same code in
> > multiple files, move the common code to a different file
> > and call those functions from the respective da830/da850
> > files.
> > 
> > Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > Acked-by: Nick Thompson <nick.thompson@ge.com>
> > Acked-by: Ben Gardiner <bengardiner@nanometrics.ca>
> > ---
> > Since v1:
> > Added irq_init declaration in misc.h to avoid compiler warning.
> 
> This patch causes the following compiler warning for me:
> 
> -> ./MAKEALL da830evm da850evm
> Configuring for da830evm board...
> da830evm.c:124: warning: missing braces around initializer
> da830evm.c:124: warning: (near initialization for 'lpsc[0]')
> 
> 122
> 123 static const struct lpsc_resource lpsc[] = {
> 124         DAVINCI_LPSC_AEMIF,     /* NAND, NOR */
> 125         DAVINCI_LPSC_SPI0,      /* Serial Flash */
> 126         DAVINCI_LPSC_EMAC,      /* image download */
> 127         DAVINCI_LPSC_UART2,     /* console */
> 128         DAVINCI_LPSC_GPIO,
> 129 };
> 

I'll fix this and re-submit the patch.

Thanks,
Sudhakar