From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Samuel Holland'" <samuel@sholland.org>, <u-boot@lists.denx.de>,
"'Jagan Teki'" <jagan@amarulasolutions.com>,
"'Andre Przywara'" <andre.przywara@arm.com>
Cc: "'Peng Fan'" <peng.fan@nxp.com>
Subject: RE: [PATCH 2/2] sunxi: mmc: Move header to the driver directory
Date: Tue, 31 Oct 2023 15:30:28 +0900 [thread overview]
Message-ID: <004601da0bc3$bd389060$37a9b120$@samsung.com> (raw)
In-Reply-To: <20231031052246.63019-2-samuel@sholland.org>
> -----Original Message-----
> From: Samuel Holland <samuel@sholland.org>
> Sent: Tuesday, October 31, 2023 2:23 PM
> To: u-boot@lists.denx.de; Jagan Teki <jagan@amarulasolutions.com>; Andre Przywara
> <andre.przywara@arm.com>
> Cc: Samuel Holland <samuel@sholland.org>; Jaehoon Chung <jh80.chung@samsung.com>; Peng Fan
> <peng.fan@nxp.com>
> Subject: [PATCH 2/2] sunxi: mmc: Move header to the driver directory
>
> The MMC controller driver is (and ought to be) the only user of these
> register definitions. Put them in a header next to the driver to remove
> the dependency on a specific ARM platform's headers.
>
> Due to the sunxi_mmc_init() prototype, the file was not renamed. None of
> the register definitions were changed.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> arch/arm/include/asm/arch-sunxi/mmc.h | 139 +-------------------------
> drivers/mmc/sunxi_mmc.c | 4 +
> drivers/mmc/sunxi_mmc.h | 138 +++++++++++++++++++++++++
> 3 files changed, 146 insertions(+), 135 deletions(-)
> create mode 100644 drivers/mmc/sunxi_mmc.h
>
> diff --git a/arch/arm/include/asm/arch-sunxi/mmc.h b/arch/arm/include/asm/arch-sunxi/mmc.h
> index 8ed3e0459c9..b8d91b5c64b 100644
> --- a/arch/arm/include/asm/arch-sunxi/mmc.h
> +++ b/arch/arm/include/asm/arch-sunxi/mmc.h
> @@ -1,139 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * (C) Copyright 2007-2011
> - * Allwinner Technology Co., Ltd. <https://protect2.fireeye.com/v1/url?k=4cb2b925-2d39ac0a-4cb3326a-
> 74fe485cbfe7-043aa1e18727af33&q=1&e=c27b74b1-be1d-4124-b8c0-
> 7d4a5f8076a3&u=http%3A%2F%2Fwww.allwinnertech.com%2F>
> - * Aaron <leafy.myeh@allwinnertech.com>
> - *
> - * MMC register definition for allwinner sunxi platform.
> - */
>
> -#ifndef _SUNXI_MMC_H
> -#define _SUNXI_MMC_H
> -
> -#include <linux/types.h>
> -
> -struct sunxi_mmc {
> - u32 gctrl; /* 0x00 global control */
> - u32 clkcr; /* 0x04 clock control */
> - u32 timeout; /* 0x08 time out */
> - u32 width; /* 0x0c bus width */
> - u32 blksz; /* 0x10 block size */
> - u32 bytecnt; /* 0x14 byte count */
> - u32 cmd; /* 0x18 command */
> - u32 arg; /* 0x1c argument */
> - u32 resp0; /* 0x20 response 0 */
> - u32 resp1; /* 0x24 response 1 */
> - u32 resp2; /* 0x28 response 2 */
> - u32 resp3; /* 0x2c response 3 */
> - u32 imask; /* 0x30 interrupt mask */
> - u32 mint; /* 0x34 masked interrupt status */
> - u32 rint; /* 0x38 raw interrupt status */
> - u32 status; /* 0x3c status */
> - u32 ftrglevel; /* 0x40 FIFO threshold watermark*/
> - u32 funcsel; /* 0x44 function select */
> - u32 cbcr; /* 0x48 CIU byte count */
> - u32 bbcr; /* 0x4c BIU byte count */
> - u32 dbgc; /* 0x50 debug enable */
> - u32 res0; /* 0x54 reserved */
> - u32 a12a; /* 0x58 Auto command 12 argument */
> - u32 ntsr; /* 0x5c New timing set register */
> - u32 res1[8];
> - u32 dmac; /* 0x80 internal DMA control */
> - u32 dlba; /* 0x84 internal DMA descr list base address */
> - u32 idst; /* 0x88 internal DMA status */
> - u32 idie; /* 0x8c internal DMA interrupt enable */
> - u32 chda; /* 0x90 */
> - u32 cbda; /* 0x94 */
> - u32 res2[26];
> -#if defined(CONFIG_SUNXI_GEN_SUN6I) || defined(CONFIG_SUN50I_GEN_H6) ||
> defined(CONFIG_SUNXI_GEN_NCAT2)
> - u32 res3[17];
> - u32 samp_dl;
> - u32 res4[46];
> -#endif
> - u32 fifo; /* 0x100 / 0x200 FIFO access address */
> -};
> -
> -#define SUNXI_MMC_CLK_POWERSAVE (0x1 << 17)
> -#define SUNXI_MMC_CLK_ENABLE (0x1 << 16)
> -#define SUNXI_MMC_CLK_DIVIDER_MASK (0xff)
> -
> -#define SUNXI_MMC_GCTRL_SOFT_RESET (0x1 << 0)
> -#define SUNXI_MMC_GCTRL_FIFO_RESET (0x1 << 1)
> -#define SUNXI_MMC_GCTRL_DMA_RESET (0x1 << 2)
> -#define SUNXI_MMC_GCTRL_RESET (SUNXI_MMC_GCTRL_SOFT_RESET|\
> - SUNXI_MMC_GCTRL_FIFO_RESET|\
> - SUNXI_MMC_GCTRL_DMA_RESET)
> -#define SUNXI_MMC_GCTRL_DMA_ENABLE (0x1 << 5)
> -#define SUNXI_MMC_GCTRL_ACCESS_BY_AHB (0x1 << 31)
> -
> -#define SUNXI_MMC_CMD_RESP_EXPIRE (0x1 << 6)
> -#define SUNXI_MMC_CMD_LONG_RESPONSE (0x1 << 7)
> -#define SUNXI_MMC_CMD_CHK_RESPONSE_CRC (0x1 << 8)
> -#define SUNXI_MMC_CMD_DATA_EXPIRE (0x1 << 9)
> -#define SUNXI_MMC_CMD_WRITE (0x1 << 10)
> -#define SUNXI_MMC_CMD_AUTO_STOP (0x1 << 12)
> -#define SUNXI_MMC_CMD_WAIT_PRE_OVER (0x1 << 13)
> -#define SUNXI_MMC_CMD_SEND_INIT_SEQ (0x1 << 15)
> -#define SUNXI_MMC_CMD_UPCLK_ONLY (0x1 << 21)
> -#define SUNXI_MMC_CMD_START (0x1 << 31)
> -
> -#define SUNXI_MMC_RINT_RESP_ERROR (0x1 << 1)
> -#define SUNXI_MMC_RINT_COMMAND_DONE (0x1 << 2)
> -#define SUNXI_MMC_RINT_DATA_OVER (0x1 << 3)
> -#define SUNXI_MMC_RINT_TX_DATA_REQUEST (0x1 << 4)
> -#define SUNXI_MMC_RINT_RX_DATA_REQUEST (0x1 << 5)
> -#define SUNXI_MMC_RINT_RESP_CRC_ERROR (0x1 << 6)
> -#define SUNXI_MMC_RINT_DATA_CRC_ERROR (0x1 << 7)
> -#define SUNXI_MMC_RINT_RESP_TIMEOUT (0x1 << 8)
> -#define SUNXI_MMC_RINT_DATA_TIMEOUT (0x1 << 9)
> -#define SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE (0x1 << 10)
> -#define SUNXI_MMC_RINT_FIFO_RUN_ERROR (0x1 << 11)
> -#define SUNXI_MMC_RINT_HARD_WARE_LOCKED (0x1 << 12)
> -#define SUNXI_MMC_RINT_START_BIT_ERROR (0x1 << 13)
> -#define SUNXI_MMC_RINT_AUTO_COMMAND_DONE (0x1 << 14)
> -#define SUNXI_MMC_RINT_END_BIT_ERROR (0x1 << 15)
> -#define SUNXI_MMC_RINT_SDIO_INTERRUPT (0x1 << 16)
> -#define SUNXI_MMC_RINT_CARD_INSERT (0x1 << 30)
> -#define SUNXI_MMC_RINT_CARD_REMOVE (0x1 << 31)
> -#define SUNXI_MMC_RINT_INTERRUPT_ERROR_BIT \
> - (SUNXI_MMC_RINT_RESP_ERROR | \
> - SUNXI_MMC_RINT_RESP_CRC_ERROR | \
> - SUNXI_MMC_RINT_DATA_CRC_ERROR | \
> - SUNXI_MMC_RINT_RESP_TIMEOUT | \
> - SUNXI_MMC_RINT_DATA_TIMEOUT | \
> - SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE | \
> - SUNXI_MMC_RINT_FIFO_RUN_ERROR | \
> - SUNXI_MMC_RINT_HARD_WARE_LOCKED | \
> - SUNXI_MMC_RINT_START_BIT_ERROR | \
> - SUNXI_MMC_RINT_END_BIT_ERROR) /* 0xbfc2 */
> -#define SUNXI_MMC_RINT_INTERRUPT_DONE_BIT \
> - (SUNXI_MMC_RINT_AUTO_COMMAND_DONE | \
> - SUNXI_MMC_RINT_DATA_OVER | \
> - SUNXI_MMC_RINT_COMMAND_DONE | \
> - SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE)
> -
> -#define SUNXI_MMC_STATUS_RXWL_FLAG (0x1 << 0)
> -#define SUNXI_MMC_STATUS_TXWL_FLAG (0x1 << 1)
> -#define SUNXI_MMC_STATUS_FIFO_EMPTY (0x1 << 2)
> -#define SUNXI_MMC_STATUS_FIFO_FULL (0x1 << 3)
> -#define SUNXI_MMC_STATUS_CARD_PRESENT (0x1 << 8)
> -#define SUNXI_MMC_STATUS_CARD_DATA_BUSY (0x1 << 9)
> -#define SUNXI_MMC_STATUS_DATA_FSM_BUSY (0x1 << 10)
> -#define SUNXI_MMC_STATUS_FIFO_LEVEL(reg) (((reg) >> 17) & 0x3fff)
> -
> -#define SUNXI_MMC_NTSR_MODE_SEL_NEW (0x1 << 31)
> -
> -#define SUNXI_MMC_IDMAC_RESET (0x1 << 0)
> -#define SUNXI_MMC_IDMAC_FIXBURST (0x1 << 1)
> -#define SUNXI_MMC_IDMAC_ENABLE (0x1 << 7)
> -
> -#define SUNXI_MMC_IDIE_TXIRQ (0x1 << 0)
> -#define SUNXI_MMC_IDIE_RXIRQ (0x1 << 1)
> -
> -#define SUNXI_MMC_COMMON_CLK_GATE (1 << 16)
> -#define SUNXI_MMC_COMMON_RESET (1 << 18)
> -
> -#define SUNXI_MMC_CAL_DL_SW_EN (0x1 << 7)
> +#ifndef _ASM_ARCH_MMC_H_
> +#define _ASM_ARCH_MMC_H_
>
> struct mmc *sunxi_mmc_init(int sdc_no);
> -#endif /* _SUNXI_MMC_H */
> +
> +#endif /* _ASM_ARCH_MMC_H_ */
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> index 7caefa153dc..714706d2411 100644
> --- a/drivers/mmc/sunxi_mmc.c
> +++ b/drivers/mmc/sunxi_mmc.c
> @@ -25,10 +25,14 @@
> #include <asm/io.h>
> #include <asm/arch/clock.h>
> #include <asm/arch/cpu.h>
> +#if !CONFIG_IS_ENABLED(DM_MMC)
> #include <asm/arch/mmc.h>
> +#endif
> #include <linux/delay.h>
> #include <sunxi_gpio.h>
>
> +#include "sunxi_mmc.h"
> +
> #ifndef CCM_MMC_CTRL_MODE_SEL_NEW
> #define CCM_MMC_CTRL_MODE_SEL_NEW 0
> #endif
> diff --git a/drivers/mmc/sunxi_mmc.h b/drivers/mmc/sunxi_mmc.h
> new file mode 100644
> index 00000000000..f4ae5a790c8
> --- /dev/null
> +++ b/drivers/mmc/sunxi_mmc.h
> @@ -0,0 +1,138 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * (C) Copyright 2007-2011
> + * Allwinner Technology Co., Ltd. <https://protect2.fireeye.com/v1/url?k=31fd542e-50764101-31fcdf61-
> 74fe485cbfe7-6b37535e8d2e0d96&q=1&e=c27b74b1-be1d-4124-b8c0-
> 7d4a5f8076a3&u=http%3A%2F%2Fwww.allwinnertech.com%2F>
> + * Aaron <leafy.myeh@allwinnertech.com>
> + *
> + * MMC register definition for allwinner sunxi platform.
> + */
> +
> +#ifndef _SUNXI_MMC_H
> +#define _SUNXI_MMC_H
> +
> +#include <linux/types.h>
> +
> +struct sunxi_mmc {
> + u32 gctrl; /* 0x00 global control */
> + u32 clkcr; /* 0x04 clock control */
> + u32 timeout; /* 0x08 time out */
> + u32 width; /* 0x0c bus width */
> + u32 blksz; /* 0x10 block size */
> + u32 bytecnt; /* 0x14 byte count */
> + u32 cmd; /* 0x18 command */
> + u32 arg; /* 0x1c argument */
> + u32 resp0; /* 0x20 response 0 */
> + u32 resp1; /* 0x24 response 1 */
> + u32 resp2; /* 0x28 response 2 */
> + u32 resp3; /* 0x2c response 3 */
> + u32 imask; /* 0x30 interrupt mask */
> + u32 mint; /* 0x34 masked interrupt status */
> + u32 rint; /* 0x38 raw interrupt status */
> + u32 status; /* 0x3c status */
> + u32 ftrglevel; /* 0x40 FIFO threshold watermark*/
> + u32 funcsel; /* 0x44 function select */
> + u32 cbcr; /* 0x48 CIU byte count */
> + u32 bbcr; /* 0x4c BIU byte count */
> + u32 dbgc; /* 0x50 debug enable */
> + u32 res0; /* 0x54 reserved */
> + u32 a12a; /* 0x58 Auto command 12 argument */
> + u32 ntsr; /* 0x5c New timing set register */
> + u32 res1[8];
> + u32 dmac; /* 0x80 internal DMA control */
> + u32 dlba; /* 0x84 internal DMA descr list base address */
> + u32 idst; /* 0x88 internal DMA status */
> + u32 idie; /* 0x8c internal DMA interrupt enable */
> + u32 chda; /* 0x90 */
> + u32 cbda; /* 0x94 */
> + u32 res2[26];
> +#if defined(CONFIG_SUNXI_GEN_SUN6I) || defined(CONFIG_SUN50I_GEN_H6) ||
> defined(CONFIG_SUNXI_GEN_NCAT2)
> + u32 res3[17];
> + u32 samp_dl;
> + u32 res4[46];
> +#endif
> + u32 fifo; /* 0x100 / 0x200 FIFO access address */
> +};
> +
> +#define SUNXI_MMC_CLK_POWERSAVE (0x1 << 17)
> +#define SUNXI_MMC_CLK_ENABLE (0x1 << 16)
> +#define SUNXI_MMC_CLK_DIVIDER_MASK (0xff)
> +
> +#define SUNXI_MMC_GCTRL_SOFT_RESET (0x1 << 0)
> +#define SUNXI_MMC_GCTRL_FIFO_RESET (0x1 << 1)
> +#define SUNXI_MMC_GCTRL_DMA_RESET (0x1 << 2)
> +#define SUNXI_MMC_GCTRL_RESET (SUNXI_MMC_GCTRL_SOFT_RESET|\
> + SUNXI_MMC_GCTRL_FIFO_RESET|\
> + SUNXI_MMC_GCTRL_DMA_RESET)
> +#define SUNXI_MMC_GCTRL_DMA_ENABLE (0x1 << 5)
> +#define SUNXI_MMC_GCTRL_ACCESS_BY_AHB (0x1 << 31)
> +
> +#define SUNXI_MMC_CMD_RESP_EXPIRE (0x1 << 6)
> +#define SUNXI_MMC_CMD_LONG_RESPONSE (0x1 << 7)
> +#define SUNXI_MMC_CMD_CHK_RESPONSE_CRC (0x1 << 8)
> +#define SUNXI_MMC_CMD_DATA_EXPIRE (0x1 << 9)
> +#define SUNXI_MMC_CMD_WRITE (0x1 << 10)
> +#define SUNXI_MMC_CMD_AUTO_STOP (0x1 << 12)
> +#define SUNXI_MMC_CMD_WAIT_PRE_OVER (0x1 << 13)
> +#define SUNXI_MMC_CMD_SEND_INIT_SEQ (0x1 << 15)
> +#define SUNXI_MMC_CMD_UPCLK_ONLY (0x1 << 21)
> +#define SUNXI_MMC_CMD_START (0x1 << 31)
> +
> +#define SUNXI_MMC_RINT_RESP_ERROR (0x1 << 1)
> +#define SUNXI_MMC_RINT_COMMAND_DONE (0x1 << 2)
> +#define SUNXI_MMC_RINT_DATA_OVER (0x1 << 3)
> +#define SUNXI_MMC_RINT_TX_DATA_REQUEST (0x1 << 4)
> +#define SUNXI_MMC_RINT_RX_DATA_REQUEST (0x1 << 5)
> +#define SUNXI_MMC_RINT_RESP_CRC_ERROR (0x1 << 6)
> +#define SUNXI_MMC_RINT_DATA_CRC_ERROR (0x1 << 7)
> +#define SUNXI_MMC_RINT_RESP_TIMEOUT (0x1 << 8)
> +#define SUNXI_MMC_RINT_DATA_TIMEOUT (0x1 << 9)
> +#define SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE (0x1 << 10)
> +#define SUNXI_MMC_RINT_FIFO_RUN_ERROR (0x1 << 11)
> +#define SUNXI_MMC_RINT_HARD_WARE_LOCKED (0x1 << 12)
> +#define SUNXI_MMC_RINT_START_BIT_ERROR (0x1 << 13)
> +#define SUNXI_MMC_RINT_AUTO_COMMAND_DONE (0x1 << 14)
> +#define SUNXI_MMC_RINT_END_BIT_ERROR (0x1 << 15)
> +#define SUNXI_MMC_RINT_SDIO_INTERRUPT (0x1 << 16)
> +#define SUNXI_MMC_RINT_CARD_INSERT (0x1 << 30)
> +#define SUNXI_MMC_RINT_CARD_REMOVE (0x1 << 31)
> +#define SUNXI_MMC_RINT_INTERRUPT_ERROR_BIT \
> + (SUNXI_MMC_RINT_RESP_ERROR | \
> + SUNXI_MMC_RINT_RESP_CRC_ERROR | \
> + SUNXI_MMC_RINT_DATA_CRC_ERROR | \
> + SUNXI_MMC_RINT_RESP_TIMEOUT | \
> + SUNXI_MMC_RINT_DATA_TIMEOUT | \
> + SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE | \
> + SUNXI_MMC_RINT_FIFO_RUN_ERROR | \
> + SUNXI_MMC_RINT_HARD_WARE_LOCKED | \
> + SUNXI_MMC_RINT_START_BIT_ERROR | \
> + SUNXI_MMC_RINT_END_BIT_ERROR) /* 0xbfc2 */
> +#define SUNXI_MMC_RINT_INTERRUPT_DONE_BIT \
> + (SUNXI_MMC_RINT_AUTO_COMMAND_DONE | \
> + SUNXI_MMC_RINT_DATA_OVER | \
> + SUNXI_MMC_RINT_COMMAND_DONE | \
> + SUNXI_MMC_RINT_VOLTAGE_CHANGE_DONE)
> +
> +#define SUNXI_MMC_STATUS_RXWL_FLAG (0x1 << 0)
> +#define SUNXI_MMC_STATUS_TXWL_FLAG (0x1 << 1)
> +#define SUNXI_MMC_STATUS_FIFO_EMPTY (0x1 << 2)
> +#define SUNXI_MMC_STATUS_FIFO_FULL (0x1 << 3)
> +#define SUNXI_MMC_STATUS_CARD_PRESENT (0x1 << 8)
> +#define SUNXI_MMC_STATUS_CARD_DATA_BUSY (0x1 << 9)
> +#define SUNXI_MMC_STATUS_DATA_FSM_BUSY (0x1 << 10)
> +#define SUNXI_MMC_STATUS_FIFO_LEVEL(reg) (((reg) >> 17) & 0x3fff)
> +
> +#define SUNXI_MMC_NTSR_MODE_SEL_NEW (0x1 << 31)
> +
> +#define SUNXI_MMC_IDMAC_RESET (0x1 << 0)
> +#define SUNXI_MMC_IDMAC_FIXBURST (0x1 << 1)
> +#define SUNXI_MMC_IDMAC_ENABLE (0x1 << 7)
> +
> +#define SUNXI_MMC_IDIE_TXIRQ (0x1 << 0)
> +#define SUNXI_MMC_IDIE_RXIRQ (0x1 << 1)
> +
> +#define SUNXI_MMC_COMMON_CLK_GATE (1 << 16)
> +#define SUNXI_MMC_COMMON_RESET (1 << 18)
> +
> +#define SUNXI_MMC_CAL_DL_SW_EN (0x1 << 7)
> +
> +#endif /* _SUNXI_MMC_H */
> --
> 2.41.0
next prev parent reply other threads:[~2023-10-31 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231031052252epcas1p2427a69ef9d0d8ee856242f44e03d2c47@epcas1p2.samsung.com>
2023-10-31 5:22 ` [PATCH 1/2] sunxi: mmc: Sort compatible strings numerically Samuel Holland
2023-10-31 5:22 ` [PATCH 2/2] sunxi: mmc: Move header to the driver directory Samuel Holland
2023-10-31 6:30 ` Jaehoon Chung [this message]
2023-10-31 6:29 ` [PATCH 1/2] sunxi: mmc: Sort compatible strings numerically Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601da0bc3$bd389060$37a9b120$@samsung.com' \
--to=jh80.chung@samsung.com \
--cc=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox