public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf.samuelsson@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)
Date: Fri, 13 Jun 2008 09:18:36 +0200	[thread overview]
Message-ID: <004901c8cd27$0da70f50$0d0514ac@atmel.com> (raw)
In-Reply-To: 20080613063826.14BB4248CE@gemini.denx.de

Wolfgang Denk wrote:
> In message <005801c8ccb1$1cd66730$0c0514ac@atmel.com> you wrote:
>> 
>> If you want to see changes right now,
>> then just replace the existing file with the Diopsis file and do a
>> diff. 
> 
> No, this is not the way we work. We submit patches that can be
> reviewed, not chunks of code that the reviewer has to anayze with
> additional, unnecessary efforts.

Antonio submits a working patchset which is structured in the
same manner as existing boards.
Haavard has a different goal which is important, but less urgent than other things.

>> Why not get the Diopsis support in first, and then do the merge
>> afterwards. 
> 
> Because this is NOT the way it works.
> Please stick to the established rules.

Which rule is you referring to?

Since Haavard wants this merge, then I suggest that Haavard takes
the existing patches from Antonio and reworks them ASAP,
testing them out on AVR32, AT91 and Diopsis, and resubmits
the patchset so that we have a working common driver
and working AT572D940DF board support.

Haavard, There is an AT572D940HF-EB in Atmel Norway, 
I gave it to OJ and he should forward it to Haakan.
Do you have any AT91 boards?

> 
> Best regards,
> 
> Wolfgang Denk

Best Regards
Ulf Samuelsson                ulf at atmel.com
Atmel Nordic AB
Mail:  Box 2033, 174 02 Sundbyberg, Sweden
Visit:  Kavalleriv?gen 24, 174 58 Sundbyberg, Sweden
Phone +46 (8) 441 54 22     Fax +46 (8) 441 54 29
GSM    +46 (706) 22 44 57


Technical support when I am not available:
AT90 AVR Applications Group: mailto:avr at atmel.com
AT91 ARM Applications Group: mailto:at91support at atmel.com
AVR32 Applications Group        mailto:avr32 at atmel.com
http://www.avrfreaks.net/;            http://avr32linux.org/
http://www.at91.com/ ;                 http://www.linux4sam.org/

  reply	other threads:[~2008-06-13  7:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 14:14 [U-Boot-Users] [PATCH 1/6] AT572D940HF-EB Support v2 (board folder) Antonio R. Costa
2008-06-12 14:14 ` [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1) Antonio R. Costa
2008-06-12 14:14   ` [U-Boot-Users] [PATCH 2/2] AT572D940HF-EB Support v2 (SDHC support part 2) Antonio R. Costa
2008-06-12 14:14     ` [U-Boot-Users] [PATCH 3/6] AT572D940HF-EB Support v2 (include files part 1) Antonio R. Costa
2008-06-12 14:14       ` [U-Boot-Users] [PATCH 4/6] AT572D940HF-EB Support v2 (include files part 2) Antonio R. Costa
2008-06-12 14:15         ` [U-Boot-Users] [PATCH 5/6] AT572D940HF-EB Support v2 (ethernet files) Antonio R. Costa
2008-07-05 20:38         ` [U-Boot-Users] [PATCH 4/6] AT572D940HF-EB Support v2 (include files part 2) Jean-Christophe PLAGNIOL-VILLARD
2008-06-12 16:36   ` [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1) Haavard Skinnemoen
2008-06-12 17:19     ` Ulf Samuelsson
2008-06-12 17:31       ` Haavard Skinnemoen
2008-06-12 19:49         ` Ulf Samuelsson
2008-06-13  6:38       ` Wolfgang Denk
2008-06-13  7:18         ` Ulf Samuelsson [this message]
2008-06-13  7:53           ` Haavard Skinnemoen
2008-07-05 16:58         ` Jean-Christophe PLAGNIOL-VILLARD
2008-06-12 17:27     ` [U-Boot-Users] [PATCH 0/3] Move atmel_mci driver into drivers/mmc Haavard Skinnemoen
2008-06-12 17:27       ` [U-Boot-Users] [PATCH 1/3] Create drivers/mmc subdirectory Haavard Skinnemoen
2008-06-12 17:27         ` [U-Boot-Users] [PATCH 2/3] avr32: Use CONFIG_ATMEL_MCI to select the atmel_mci driver Haavard Skinnemoen
2008-06-12 17:27           ` [U-Boot-Users] [PATCH 3/3] mmc: Move atmel_mci driver into drivers/mmc Haavard Skinnemoen
2008-07-09 22:06             ` Wolfgang Denk
2008-07-09 22:05           ` [U-Boot-Users] [PATCH 2/3] avr32: Use CONFIG_ATMEL_MCI to select the atmel_mci driver Wolfgang Denk
2008-07-10 10:20             ` Haavard Skinnemoen
2008-07-09 22:02         ` [U-Boot-Users] [PATCH 1/3] Create drivers/mmc subdirectory Wolfgang Denk
2008-07-05 17:01       ` [U-Boot-Users] [PATCH 0/3] Move atmel_mci driver into drivers/mmc Jean-Christophe PLAGNIOL-VILLARD
2008-07-05 22:32       ` Wolfgang Denk
2008-07-06 12:01         ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004901c8cd27$0da70f50$0d0514ac@atmel.com' \
    --to=ulf.samuelsson@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox