From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Nicolas_Lacressonni=E8re?= <nlacressonniere@atmel.fr>
Date: Wed, 4 Jun 2003 10:00:39 +0200
Subject: [U-Boot-Users] [PATCH] DataFlash for AT91RM9200DK board 
References: <20030603165703.A893CC5492@atlas.denx.de>
Message-ID: <004f01c32a6f$63dcd860$91f59f0a@pc0752>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang,

> Why do we need a special command to access  the  DataFlash?  I  would
> like to see the same interface as for all other flash devices.

The DataFlash is a serial flash which is accessed like a serial eeprom. That
is why we decided to create a special command to access it.

Concerning the other points, we will make the corrections.

Best regards.

Nicolas.
-----------------------------------------------------------------
Nicolas Lacressonniere
ARM-based Products
Application Group
ATMEL Rousset - Zone Industrielle
Fab7 - 13106 Rousset Cedex
nlacressonniere at atmel.fr
Phone: 33 (0) 442 53 72 54
-----------------------------------------------------------------
----- Original Message -----
From: "Wolfgang Denk" <wd@denx.de>
To: "Nicolas Lacressonni?re" <nlacressonniere@atmel.fr>
Cc: "u-boot Mailing List" <u-boot-users@lists.sourceforge.net>; "Hamid
Ikdoumi" <hikdoumi@atmel.fr>; "Olivier Debicki" <odebicki@atmel.fr>
Sent: Tuesday, June 03, 2003 6:56 PM
Subject: Re: [U-Boot-Users] [PATCH] DataFlash for AT91RM9200DK board


> Dear Nicolas,
>
> in message <031601c329e5$0c9fba70$91f59f0a@pc0752> you wrote:
> >
> > Find attached a patch applied against the 0.3.0 release.
> >
> > It implements several changes for Atmel AT91RM9200DK development kit.
> > - Add Atmel DataFlash support for reading and writing (new entry
CFG_CMD_=
> > DATAFLASH in cmd_confdefs.h file)
>
> Why do we need a special command to access  the  DataFlash?  I  would
> like to see the same interface as for all other flash devices.
>
> Also, why did you  place  drivers/at45.c  in  the  (common)  drivers/
> directory? It seems to be very CPU-specific code to me?
>
> Thinking twice, the same is true for drivers/at91rm9200_ether.c: this
> code should IMHO go to a CPU dependend  directory,  but  not  to  the
> common drivers/ directory.
>
> > - Add Flash detection between AT49BV1614 and AT49BV1614A flashes.
>
> Your flash protection mechanism seems to be based on  some  #define'd
> CFG_* parameters; please check our changes in the current CVS version
> to  get  rid  of such constants (like CFG_MON_LEN). Maybe you want to
> adjust your code?
>
> > - Replace old Ethernet PHY configuration functions
> > - New link address
>
> Some files (drivers/at91rm9200_ether.c,
> include/AT91C_SPI_DataFlash.h,
> include/asm-arm/arch-at91rm9200/AT91RM9200.h, include/dataflash.h) do
> not contain GPL headers and/or copyright notices. Can you please add
> / fix these?
>
>
> And please remove all C++ style comments  (//),  and  trailing  white
> space.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
> Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
> There is an order of things in this universe.
> -- Apollo, "Who Mourns for Adonais?" stardate 3468.1
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: eBay
> Get office equipment for less on eBay!
> http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
>