From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sangmoon Kim Date: Fri, 19 Aug 2005 12:22:58 +0900 Subject: [U-Boot-Users] [Patch] KVME080 Support References: <20050818204152.36097353CE9@atlas.denx.de> Message-ID: <005001c5a46d$4fb80e20$212d4cdc@smkim> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, > > Can you please split your patch into two? > I splited the patch and extracted KVME080 parts only. > > And please cleanup your code before re-submitting: > > * It violates the coding style requirements (trailing white space). > Sorry, I was suprised that my code had so many white spaces. I am sure I fixed all of it now. > * Using globally visible preprocessor defines like FLASH_WRITE64 is > not acceptable (you also forgot to document these, but that would > help either), and defining such code in the board config file is > the wrong way to implement it either. The board config file is - > ummm, a _configuration_ file, but does not contain source code. > I deleted the 'source code' from the board configuration file. The current version of KVME080 board runs well without patching cfi_flash.c I'll find an alternative way and send the patch for cfi_flash.c later. > > Also: please read the recent "U-Boot Developer's Information" > posting; you are supposed to provide a "sign-off" line for all > patches. > I added the "sign-off" line at the end of the patch. Regards, Sangmoon Kim -------------- next part -------------- A non-text attachment was scrubbed... Name: kvme080.patch.gz Type: application/x-gzip Size: 7760 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20050819/50c86749/attachment.bin