public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Simon Glass'" <sjg@chromium.org>
Cc: "'Nikhil M Jain'" <n-jain1@ti.com>,
	"'Marek Vasut'" <marex@denx.de>, <u-boot@lists.denx.de>
Subject: RE: [PATCH] spl: bootstage: move bootstage_stash before jumping to image
Date: Tue, 29 Aug 2023 12:45:59 +0900	[thread overview]
Message-ID: <005901d9da2b$52f9ece0$f8edc6a0$@samsung.com> (raw)
In-Reply-To: <CAPnjgZ1YYHTe_7VZDyCe9OhrmhhdtnOn5szeXfrJma6=Ot39ZA@mail.gmail.com>

Hi Simon,

> -----Original Message-----
> From: Simon Glass <sjg@chromium.org>
> Sent: Tuesday, August 29, 2023 2:55 AM
> To: Chanho Park <chanho61.park@samsung.com>
> Cc: Nikhil M Jain <n-jain1@ti.com>; Marek Vasut <marex@denx.de>; u-
> boot@lists.denx.de
> Subject: Re: [PATCH] spl: bootstage: move bootstage_stash before jumping
> to image
> 
> Hi Chanho,
> 
> On Mon, 28 Aug 2023 at 03:46, Chanho Park <chanho61.park@samsung.com>
> wrote:
> >
> > For IH_OS_OPENSBI and IH_OS_LINUX, there is no chance to stash
> > bootstare record because it will not return after jumping to the image.
> > Hence, this patch moves the location of bootstage_stash before jumping
> > to image.
> >
> 
> Please fix your implementation instead. You must jump to the OS at the end
> of this function and not before.

In case of OS_TEE/OPENSBI/LINUX images, they will not be returned to SPL so they can't get a chance to stash boot stage records.

> 
> In fact I have a patch to move bootstage later in this function!

Will you post the patch soon? Or it was already posted?

Best Regards,
Chanho Park


  reply	other threads:[~2023-08-29  3:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230828094628epcas2p39068c0277081701446115fec7584ab54@epcas2p3.samsung.com>
2023-08-28  9:46 ` [PATCH] spl: bootstage: move bootstage_stash before jumping to image Chanho Park
2023-08-28 17:54   ` Simon Glass
2023-08-29  3:45     ` Chanho Park [this message]
2023-08-29 16:38       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005901d9da2b$52f9ece0$f8edc6a0$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=marex@denx.de \
    --cc=n-jain1@ti.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox