From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Tue, 9 Jan 2018 00:11:51 +0100 Subject: [U-Boot] [PATCH 11/16] efi_loader: implement DisconnectController In-Reply-To: References: <20171217154342.15469-1-xypron.glpk@gmx.de> <20171217154342.15469-12-xypron.glpk@gmx.de> Message-ID: <00703c26-e99f-39ab-e4e2-b4e15757d37b@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/08/2018 04:35 AM, Simon Glass wrote: > Hi Heinrich, > > On 17 December 2017 at 08:43, Heinrich Schuchardt wrote: >> Unfortunately we need a forward declaration because both >> OpenProtocol and CloseProtocol have to call DisconnectController. >> And DisconnectController calls both OpenProtcol and CloseProtocol. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> lib/efi_loader/efi_boottime.c | 283 ++++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 261 insertions(+), 22 deletions(-) > > Reviewed-by: Simon Glass > > I think it would be good to reduce the length of some of the identifies. > > e.g. numbers_of_children -> child_count or num_children number_of_children is what we used in the function definition in efi_api.h and is the name of the parameter in the UEFI spec. I understand that you do not like bloat. But I tend to get confused when parameter names differ from the spec. Regards Heinrich > > It's just too verbose for U-Boot IMO. > > - Simon >