[U-Boot-Users] [PATCH] 16-bit NAND support

[U-Boot-Users] [PATCH] 16-bit NAND support

[Zhang, Jian]

Hi,

This is a patch to add 16-bit NAND support to u-boot. It doesn't change
any existing 8-bit NAND code so it shouldn't affect any existing boards
that have 8-bit chips. I tested it in 2 TI OMAP boards, one using
software to access chip, the other one using hardware NAND controller.

Regards,
Jian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand16.patch
Type: application/octet-stream
Size: 14481 bytes
Desc: nand16.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041102/dfae27fd/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGELOG
Type: application/octet-stream
Size: 163 bytes
Desc: CHANGELOG
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041102/dfae27fd/attachment-0001.obj 

[U-Boot-Users] [PATCH] 16-bit NAND support

[Wolfgang Denk]

In message <BA2832125C3C994384FCC051CDFC7369B8A34F@dlee2k05.ent.ti.com> you wrote:
> 
> This is a patch to add 16-bit NAND support to u-boot. It doesn't change
> any existing 8-bit NAND code so it shouldn't affect any existing boards
> that have 8-bit chips. I tested it in 2 TI OMAP boards, one using

Did you actually _check_ if it has impact on exiting  boards?  Impact
on parameters like code size, for example?

Best regards,

Wolfgang Denk

-- 
See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The one charm of marriage is that it makes a  life  of  deception  a
neccessity."                                            - Oscar Wilde

[U-Boot-Users] [PATCH] 16-bit NAND support

[Pankaj GOYAL]

Hi,
    I have applied ur patch to my u-boot1.1.1 code and one error is
generated.The log is shown below.can any one please tell me what can be the
problem.And also pls tell me how do I select that whether I m going to use
8bit Nand flash or 16bit Nand flash.Is there any CONFIG variable is required
to define.I m working on a 16bit Nand flash from the Samsung.


patching file include/linux/mtd/nand.h
patching file include/linux/mtd/nand_ids.h
patching file common/cmd_nand.c
Hunk #2 FAILED at 23.
Hunk #3 succeeded at 390 (offset -4 lines).
Hunk #5 succeeded at 710 (offset -4 lines).
Hunk #7 succeeded at 863 (offset -4 lines).
Hunk #9 succeeded at 983 (offset -4 lines).
Hunk #11 succeeded at 1043 (offset -4 lines).
Hunk #13 succeeded at 1144 (offset -4 lines).
Hunk #15 succeeded at 1222 (offset -4 lines).
Hunk #17 succeeded at 1303 (offset -4 lines).
Hunk #19 succeeded at 1374 (offset -4 lines).
Hunk #21 succeeded at 1466 (offset -4 lines).
1 out of 22 hunks FAILED -- saving rejects to file common/cmd_nand.c.rej


Bye

-----Original Message-----
From: u-boot-users-admin@lists.sourceforge.net
[mailto:u-boot-users-admin at lists.sourceforge.net] On Behalf Of Zhang, Jian
Sent: Wednesday, November 03, 2004 3:52 AM
To: u-boot-users at lists.sourceforge.net
Cc: Zhang, Jian; Johnson, Steve-OMAP
Subject: [U-Boot-Users] [PATCH] 16-bit NAND support


Hi,

This is a patch to add 16-bit NAND support to u-boot. It doesn't change any
existing 8-bit NAND code so it shouldn't affect any existing boards that
have 8-bit chips. I tested it in 2 TI OMAP boards, one using software to
access chip, the other one using hardware NAND controller.

Regards,
Jian

[U-Boot-Users] [PATCH] 16-bit NAND support

[Wolfgang Denk]

In message <00bb01c4e0eb$a003b370$0f10b40a@dlh.st.com> you wrote:
>
>     I have applied ur patch to my u-boot1.1.1 code and one error is
> generated.The log is shown below.can any one please tell me what can be

Please use current code (top of CVS).

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That Microsoft, the Trabant of the operating  system  world,  may  be
glancing  over the Berlin Wall at the Audis and BMWs and Mercedes. In
their own universe Trabants and Ladas were mainstream too...
                                                   -- Evan Leibovitch

[U-Boot-Users] [PATCH] 16-bit NAND support

[Wolfgang Denk]

In message <BA2832125C3C994384FCC051CDFC7369B8A34F@dlee2k05.ent.ti.com> you wrote:
> 
> This is a patch to add 16-bit NAND support to u-boot. It doesn't change
> any existing 8-bit NAND code so it shouldn't affect any existing boards
> that have 8-bit chips. I tested it in 2 TI OMAP boards, one using
> software to access chip, the other one using hardware NAND controller.

Added, thanks.

Please don't forget the CHANGELOG entry, and _please_  stick  to  the
Coding Style!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
8 Catfish                                               = 1 Octo-puss

[U-Boot-Users] [PATCH] 16-bit NAND support

[Zhang, Jian]

Yes, it would change the code size as 16-bit nand code is added. But the
path that an 8-bit chip follows remains the same. I don't expect it
breaks any existing boards. Can someone run a test on 8-bit chip boards?

-Jian

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de]
> Sent: Tuesday, November 02, 2004 5:06 PM
> To: Zhang, Jian
> Cc: u-boot-users at lists.sourceforge.net; Johnson, Steve-OMAP
> Subject: Re: [U-Boot-Users] [PATCH] 16-bit NAND support
> 
> In message
<BA2832125C3C994384FCC051CDFC7369B8A34F@dlee2k05.ent.ti.com> you wrote:
> >
> > This is a patch to add 16-bit NAND support to u-boot. It doesn't
change
> > any existing 8-bit NAND code so it shouldn't affect any existing
boards
> > that have 8-bit chips. I tested it in 2 TI OMAP boards, one using
> 
> Did you actually _check_ if it has impact on exiting  boards?  Impact
> on parameters like code size, for example?
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "The one charm of marriage is that it makes a  life  of  deception  a
> neccessity."                                            - Oscar Wilde

[U-Boot-Users] [PATCH] 16-bit NAND support

[Wolfgang Denk]

In message <BA2832125C3C994384FCC051CDFC7369B8A351@dlee2k05.ent.ti.com> you wrote:
> Yes, it would change the code size as 16-bit nand code is added. But the
> path that an 8-bit chip follows remains the same. I don't expect it
> breaks any existing boards. Can someone run a test on 8-bit chip boards?

Even if you disable the 16 bit NAND code the code size will change as
you added new fields to some structures and tables.

So please do not claim that it does not affect  existing  boards.  It
does!

Best regards,

Wolfgang Denk

-- 
See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are some things worth dying for.
	-- Kirk, "Errand of Mercy", stardate 3201.7

[U-Boot-Users] [PATCH] 16-bit NAND support

[Woodruff, Richard]

Wolfgang,

I just eyed the patch and it didn't seem like there was much size
difference.  Compiled it might be in the order of some bytes, perhaps a
1k or 2k at worst, easy enough to tell.  At run time it will be reading
a page at a time and moving that to memory else where, so the run time
overhead of the couple structure changes probably won't change much
either. 

Is there some bit which worries you?  I didn't notice anything in a
quick look, but perhaps you did.

Regards,
Richard W.

> -----Original Message-----
> From: u-boot-users-admin at lists.sourceforge.net [mailto:u-boot-users-
> admin at lists.sourceforge.net] On Behalf Of Wolfgang Denk
> Sent: Tuesday, November 02, 2004 5:21 PM
> To: Zhang, Jian
> Cc: u-boot-users at lists.sourceforge.net; Johnson, Steve-OMAP
> Subject: Re: [U-Boot-Users] [PATCH] 16-bit NAND support
> 
> In message
<BA2832125C3C994384FCC051CDFC7369B8A351@dlee2k05.ent.ti.com>
> you wrote:
> > Yes, it would change the code size as 16-bit nand code is added. But
the
> > path that an 8-bit chip follows remains the same. I don't expect it
> > breaks any existing boards. Can someone run a test on 8-bit chip
boards?
> 
> Even if you disable the 16 bit NAND code the code size will change as
> you added new fields to some structures and tables.
> 
> So please do not claim that it does not affect  existing  boards.  It
> does!
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> There are some things worth dying for.
> 	-- Kirk, "Errand of Mercy", stardate 3201.7
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] 16-bit NAND support

[Wolfgang Denk]

In message <71555548814716479478431542AA5F8A01B1B39D@dlee2k04.ent.ti.com> you wrote:
> 
> Is there some bit which worries you?  I didn't notice anything in a
> quick look, but perhaps you did.

I'm always worried when somebody claims "this will not hurt  at  all"
but I see some sharp instruments behind his back. [Read: if he claims
"no  impact  on any other system", but the first glance shows obvious
changes in the memory footprint]


I cannot say  (yet)  is  the  implementation  is  clean,  or  if  the
additional  memory  is well spent. But this is a boot loader, and "1k
or 2k at worst" is 1 or 2 percent of the  total.  This  is  a  bigger
change  than  I  am  willing to ignore without understanding what for
this is good, and why it cannot be avoided.

Best regards,

Wolfgang Denk

-- 
See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time.                                                 - Merrick Furst