From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A275AEB64DD for ; Fri, 11 Aug 2023 05:19:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8279980181; Fri, 11 Aug 2023 07:19:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="Gwdpd+yJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6406C868DB; Fri, 11 Aug 2023 07:19:32 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D32A0800D2 for ; Fri, 11 Aug 2023 07:19:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=s-vadapalli@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37B5JRl4014524; Fri, 11 Aug 2023 00:19:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691731167; bh=XRHVEyP8bvLhdf2yeO/ZaD26eEiolWY5I8LK8N1sr9w=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=Gwdpd+yJLm9g3WyTJiSKoRItNoeNlx2c4rU9Eq61MHxb8xcnINQwF3VBkq8SzDxlP GrXYnyQvHj4lcA4sZbgmv0trAZ54Lo1rAdVbWX8ohLMtvAGPsS10gxy2u5R80zgTFZ WQE2np6Cz8iUpkLZgPqYpbMSece6CuwtUt540yHk= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37B5JRIq045271 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Aug 2023 00:19:27 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 11 Aug 2023 00:19:26 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 11 Aug 2023 00:19:26 -0500 Received: from [172.24.227.9] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37B5JNw1127569; Fri, 11 Aug 2023 00:19:24 -0500 Message-ID: <00c8bbca-28c8-4d22-4cc8-16f40146d252@ti.com> Date: Fri, 11 Aug 2023 10:49:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 CC: , , , , , Subject: Re: [PATCH] net: Fix the displayed value of bytes transferred To: Ravi Gunasekaran References: <20230810091523.3168975-1-s-vadapalli@ti.com> <133136bd-c721-1014-0b06-f57f7cc18d50@ti.com> Content-Language: en-US From: Siddharth Vadapalli In-Reply-To: <133136bd-c721-1014-0b06-f57f7cc18d50@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Ravi, On 10/08/23 17:00, Ravi Gunasekaran wrote: > Siddharth, > > On 8/10/23 2:45 PM, Siddharth Vadapalli wrote: >> In the case of NETLOOP_SUCCESS, the decimal value of the u32 variable >> "net_boot_file_size" is printed using "%d", resulting in negative values >> being reported for large file sizes. Fix this by using "%lu" to print >> the decimal value corresponding to the bytes transferred. >> >> Fixes: 1411157d8578 ("net: cosmetic: Fixup var names related to boot file") >> Signed-off-by: Siddharth Vadapalli >> --- >> net/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/net.c b/net/net.c >> index 43abbac7c3..7aaeafc247 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -716,7 +716,7 @@ restart: >> case NETLOOP_SUCCESS: >> net_cleanup_loop(); >> if (net_boot_file_size > 0) { >> - printf("Bytes transferred = %d (%x hex)\n", >> + printf("Bytes transferred = %lu (%x hex)\n", > > 'net_boot_file_size' is of type u32. Using "%lu" will throw a warning for this. > As per [0], format specifier for 'unsigned int' is "%d, %x'. > > You could perhaps change the data type of 'net_boot_file_size' to 'ulong' as well. The issue here isn't the size of the variable itself, but the format specifier. For large file sizes, the hex value printed for the variable is correct, but the decimal value is negative. > > [0] - https://u-boot.readthedocs.io/en/latest/develop/printf.html > >> net_boot_file_size, net_boot_file_size); >> env_set_hex("filesize", net_boot_file_size); >> env_set_hex("fileaddr", image_load_addr); > -- Regards, Siddharth.