[U-Boot] [PATCH] Revert "arm: config: fix default console only to specify the device"

[Seung-Woo Kim <sw0312.kim@samsung.com>]

Hello Anand,

> -----Original Message-----
> From: Anand Moon [mailto:linux.amoon at gmail.com]
> Sent: Monday, March 25, 2019 3:45 PM
> To: Seung-Woo Kim
> Cc: U-Boot Mailing List; Lukasz Majewski
> Subject: Re: [U-Boot] [PATCH] Revert "arm: config: fix default console only to specify the device"
> 
> Hi Seung-Woo,
> 
> On Tue, 20 Nov 2018 at 11:25, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> >
> > This reverts commit 232ed3ca534708527a9515c7c41bc3542949525c.
> >
> > In exynos boards, ${console} is used to set bootargs but it sets
> > without "console=", so CONFIG_DEFAULT_CONSOLE for these boards is
> > designated with "console=" but it is removed. So revert the commit.
> >
> > References for using ${console} in
> >    board/samsung/common/bootscripts/autoboot.cmd
> >    board/samsung/common/bootscripts/bootzimg.cmd
> >
> > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> > ---
> >  include/configs/odroid.h            | 4 ++--
> >  include/configs/odroid_xu3.h        | 4 ++--
> >  include/configs/s5p_goni.h          | 4 ++--
> >  include/configs/s5pc210_universal.h | 4 ++--
> >  include/configs/trats.h             | 4 ++--
> >  include/configs/trats2.h            | 4 ++--
> >  6 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/include/configs/odroid.h b/include/configs/odroid.h
> > index ad77242e38..c3520bb15f 100644
> > --- a/include/configs/odroid.h
> > +++ b/include/configs/odroid.h
> > @@ -40,7 +40,7 @@
> >  /* Console configuration */
> >
> >  #define CONFIG_BOOTCOMMAND             "run distro_bootcmd ; run autoboot"
> > -#define CONFIG_DEFAULT_CONSOLE         "ttySAC1,115200n8"
> > +#define CONFIG_DEFAULT_CONSOLE         "console=ttySAC1,115200n8\0"
> >
> >  #define CONFIG_SYS_INIT_SP_ADDR        (CONFIG_SYS_LOAD_ADDR \
> >                                         - GENERATED_GBL_DATA_SIZE)
> > @@ -157,7 +157,7 @@
> >                 "elif test -e mmc 0 uImage; then; " \
> >                         "run boot_uimg;" \
> >                 "fi;\0" \
> > -       "console=" CONFIG_DEFAULT_CONSOLE "\0" \
> > +       "console=" CONFIG_DEFAULT_CONSOLE \
> >         "mmcbootdev=0\0" \
> >         "mmcbootpart=1\0" \
> >         "mmcrootdev=0\0" \

<...>

> > --
> > 2.19.1
> 
> This revert commit breaks the booting of the Odroid U3 using latest
> u-boot on ArchLinux.
> I have just tried to install archlinux on sdcard and update the latest kernel
> after compiling the latest u-boot and upgrade.
> It fails to boot up at-least their is not console output on the serial port.
> 
> [0] https://www.spinics.net/lists/arm-kernel/msg713918.html
> 
> I shared the my input on above link.
> Can your verify this from your side.

In my case, it works fine for booting mainline kernel at least.
Can you try after "env default -a; saveenv; reset;" command from u-boot prompt?
When I cleared env, console in env is "console=console=ttySAC1,115200n8".
Please refer below my system console log from odroud-u3.

U-Boot 2019.04-rc4-00051-ge7134b9714 (Mar 26 2019 - 13:00:45 +0900)

CPU:   Exynos4412 @ 1 GHz
Model: Odroid based on Exynos4412
Type:  u3
DRAM:  2 GiB
LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling
LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling
LDO21 at TFLASH_2.8V: set 2800000 uV; enabling
MMC:   sdhci at 12530000 - probe failed: -19

Loading Environment from MMC... OK
Net:   No ethernet found.
Hit any key to stop autoboot:  0 
Odroid # 
Odroid # 
Odroid # printenv
arch=arm
autoboot=if test -e mmc 0 boot.scr; then; run boot_script; elif test -e mmc 0 Image.itb; then; run boot_fit;elif test -e mmc 0 zImage; then; run boot_zimg;elif test -e mmc 0 uImage; then; run boot_uimg;fi;
<...>
console=console=ttySAC1,115200n8
<...>
Environment size: 4657/16380 bytes
Odroid # run autoboot
55205 bytes read in 4 ms (13.2 MiB/s)
8556752 bytes read in 299 ms (27.3 MiB/s)
Kernel image @ 0x41000000 [ 0x000000 - 0x8290d0 ]
## Flattened Device Tree blob at 40800000
   Booting using the fdt blob at 0x40800000
   Loading Device Tree to 4ffef000, end 4ffff7a4 ... OK

Starting kernel ...

[    0.000000] Booting Linux on physical CPU 0xa00

Best Regards,
- Seung-Woo Kim

> 
> Best Regards
> -Anand