From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs
Date: Fri, 8 Jan 2010 10:05:46 +0530 [thread overview]
Message-ID: <010101ca901c$0d99d5b0$28cd8110$@kumar@st.com> (raw)
In-Reply-To: <1262888474.29396.1956.camel@localhost.localdomain>
Hello Peter,
> > This patch set is a reworked patch which incorporates all review
> feedbacks from
> > earlier earlier mails
> >
> > This patch set contains the support for 4 SoCs
> > SPEAr600
> > SPEAr300
> > SPEAr310
> > SPEAr320
> >
> > SPEAr is an ARM based SoC which supports rich set of peripherals like
> Ethernet,
> > USB Host, USB Device etc to support various general
> applications
> >
> > For further info on SPEAr SoC, please see README.spear also contained
> in the
> > patch set.
> >
> > Vipin (9):
> > Added README.spear
> > SPEAr600 SoC support added
> > SPEAr300 SoC support added
> > SPEAr310 SoC support added
> > SPEAr320 SoC support added
> > i2c driver support for SPEAr SoCs
> > smi driver support for SPEAr SoCs
> > nand(fsmc) driver support for SPEAr SoCs
> > usbd driver support for SPEAr SoCs
>
> It would be nice if you reordered the patches. At a glance, some of
> the
> boards added first rely on drivers added later. Eg patch 1 uses the
> I2C
> driver in patch 6. This will cause 'git bisects' to break. To prevent
> this you should add SOC + driver code first, then boards last.
> Something like:
>
> 1. Initial SPEAr SOC support
> 2. SPEAr: Add I2C support
> 3. SPEAr: Add SMI support
> ....
> 6. Add SPEAr 600 board support
> 7. Add SPEAr 300 board support
> 8. Add SPEAr 310 board support
> 9. Add SPEAr 320 board support
>
I am planning to keep the patch order as it is but I would remove
dependencies eg. SPEAr600 would not contain code that depends on
a driver added later and so on.
This should also be OK. Right?
Regards,
Vipin
next prev parent reply other threads:[~2010-01-08 4:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 11:56 [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 1/9] Added README.spear Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 2/9] SPEAr600 SoC support added Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 3/9] SPEAr300 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 4/9] SPEAr310 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 5/9] SPEAr320 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 6/9] i2c driver support for SPEAr SoCs Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 7/9] smi " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 8/9] nand(fsmc) " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 9/9] usbd " Vipin KUMAR
2010-01-09 9:50 ` Remy Bohmer
2010-01-07 16:42 ` [U-Boot] [PATCH v2 0/9] Added " Tom
2010-01-07 18:03 ` Armando VISCONTI
2010-01-08 13:28 ` Vipin KUMAR
2010-01-07 18:21 ` Peter Tyser
2010-01-08 4:35 ` Vipin KUMAR [this message]
2010-01-08 15:55 ` Peter Tyser
2010-01-08 16:43 ` Tom
2010-01-11 17:13 ` Vipin Kumar
2010-01-12 13:38 ` Tom
2010-01-08 13:31 ` Vipin KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010101ca901c$0d99d5b0$28cd8110$@kumar@st.com' \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox