From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin KUMAR <vipin.kumar@st.com>
Date: Fri, 8 Jan 2010 10:05:46 +0530
Subject: [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs
In-Reply-To: <1262888474.29396.1956.camel@localhost.localdomain>
References: <1262865390-2016-1-git-send-email-vipin.kumar@st.com>
	<1262888474.29396.1956.camel@localhost.localdomain>
Message-ID: <010101ca901c$0d99d5b0$28cd8110$@kumar@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Hello Peter,

> > This patch set is a reworked patch which incorporates all review
> feedbacks from
> > earlier earlier mails
> >
> > This patch set contains the support for 4 SoCs
> > SPEAr600
> > SPEAr300
> > SPEAr310
> > SPEAr320
> >
> > SPEAr is an ARM based SoC which supports rich set of peripherals like
> Ethernet,
> >       USB Host, USB Device etc to support various general
> applications
> >
> > For further info on SPEAr SoC, please see README.spear also contained
> in the
> > patch set.
> >
> > Vipin (9):
> >   Added README.spear
> >   SPEAr600 SoC support added
> >   SPEAr300 SoC support added
> >   SPEAr310 SoC support added
> >   SPEAr320 SoC support added
> >   i2c driver support for SPEAr SoCs
> >   smi driver support for SPEAr SoCs
> >   nand(fsmc) driver support for SPEAr SoCs
> >   usbd driver support for SPEAr SoCs
> 
> It would be nice if you reordered the patches.  At a glance, some of
> the
> boards added first rely on drivers added later.  Eg patch 1 uses the
> I2C
> driver in patch 6.  This will cause 'git bisects' to break.  To prevent
> this you should add SOC + driver code first, then boards last.
> Something like:
> 
> 1. Initial SPEAr SOC support
> 2. SPEAr: Add I2C support
> 3. SPEAr: Add SMI support
> ....
> 6. Add SPEAr 600 board support
> 7. Add SPEAr 300 board support
> 8. Add SPEAr 310 board support
> 9. Add SPEAr 320 board support
> 

I am planning to keep the patch order as it is but I would remove 
dependencies eg. SPEAr600 would not contain code that depends on
a driver added later and so on.

This should also be OK. Right?

Regards,
Vipin